Viewmanager.py: add check disk space #1212

PushKK · 2021-05-20T22:08:44Z

For https://gramps-project.org/bugs/view.php?id=12306
I add check disk space before Quit and BackUp.

Test this code please.

1. Old menu changed: Database Processing > Family Tree Processing Compare and Merge... > Merge... 2. Add string "The function ".

1. Capitalize all first letter "семейное древо" > "Семейное древо", 2. Old words from Tips.xml: Database Processing > Family Tree Processing Compare and Merge... > Merge... 3. Change: "Местоположение" > "Место" "граф" > "график" 4. Other small fix.

tosky · 2021-05-20T22:13:49Z

This looks like a duplicate of #1211 - wrong branch?

codecov-commenter · 2021-05-20T22:17:09Z

Codecov Report

Merging #1212 (24b6ae3) into master (9495d73) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1212   +/-   ##
=======================================
  Coverage   41.16%   41.16%           
=======================================
  Files        1062     1062           
  Lines      144695   144695           
=======================================
  Hits        59564    59564           
  Misses      85131    85131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9495d73...24b6ae3. Read the comment docs.

PushKK · 2021-05-21T07:14:39Z

Sorry, GitHub add all my previous PRs to last PR. Alltime.
For resolve this problem I delete my fork and create fork again...

Oh, GitHub not include .py files in this PR...

For https://gramps-project.org/bugs/view.php?id=12306

Nick-Hall · 2021-05-21T14:14:01Z

@PushKK You probably just need to rebase your branches on master.

Nick-Hall

Good idea. It just needs a little refinement.

Nick-Hall · 2021-05-21T14:24:21Z

gramps/gui/viewmanager.py

@@ -580,10 +580,47 @@ def no_del_event(self, *obj):
        hits 'x' multiple times. """
        return True

+    def checkdisk(self, dbfolder): # TODO check this function


This belongs in gramps/gen/utils/file.py.

Yes, in new PR this function move to file.py.

Nick-Hall · 2021-05-21T14:24:27Z

gramps/gui/viewmanager.py

+        """
+        Check disk space
+        """
+        if win():                               # for windows:


What should we do for Windows?

Gramps work in Windows too. it's draft for Windows. I check this code in my Linux system, but I have not Windows.

Nick-Hall · 2021-05-21T14:25:08Z

gramps/gui/viewmanager.py

+        if (self.checkdisk(config.get('database.path')) < diskspace):
+            self.uistate.push_message(self.dbstate, _("Disk space < " + str(diskspace) + " MB. Quit impossible. Clear your disk and repeat this operation."))
+            WarningDialog(
+                _("Message for user:"),


Perhaps "Low disk space" instead?

Yes, of course.
For me - after this message I must run BleachBit and clear disk.
Gramps wait me and not freeze.

Nick-Hall · 2021-05-21T14:25:36Z

gramps/gui/viewmanager.py

+        #                   - every backup (we need space 'last_backup_file_size'+ 5%)
+        diskspace = 20             # Disk space for Linux - 20 MB, for Gramps - 5 MB, for backup 'last_backup_file_size' + 5%
+        if (self.checkdisk(config.get('database.path')) < diskspace):
+            self.uistate.push_message(self.dbstate, _("Disk space < " + str(diskspace) + " MB. Quit impossible. Clear your disk and repeat this operation."))


Use format strings instead of concatenation.

I'm not Python man.

I rewrite this code. New PR have normal string concatenation.
I check code, all translated strings are present in .po file.

Nick-Hall · 2021-05-21T14:28:40Z

gramps/gui/viewmanager.py

+            if os.path.isfile(os.path.join(path, bfile)) and bfile.startswith(backup_name) and bfile.endswith(backup_ext):
+                blastfile = bfile
+
+        bfile_size = round(os.path.getsize(os.path.join(path, blastfile))/(1024))


A utility function to return the largest backup size would be neater.

I think about this - we must use biggest or last backup file.
In result - Gramps must use last backup file for active database.
Reason:
If user delete non used info from database -> new_database_size < old_database_size.
And Gramps create new_database_backup with small size.

Yes. It just needs to be put into a utility function in gramps/gen/utils/file.py.

I test this code two day.
In result - backup_file_size must be calculated from active_database_size.
For SQLite3 - database with testdata have 71 MB, backup have 4,1 MB file (> 7%).
If user create new Family tree and import to tree data from other base - Gramps must say to user:

You need least 'calculated backup_file_size' MB
or (easy way on 'try - except')

You cannot save your file. Clear your disk and try save again.

Nick-Hall · 2022-03-12T22:16:09Z

Replaced by PR #1218.

Nick-Hall · 2022-03-12T22:16:09Z

Replaced by PR #1218.

PushKK added 2 commits May 20, 2021 21:04

Tips.xml: Old string changed

84f62bb

1. Old menu changed: Database Processing > Family Tree Processing Compare and Merge... > Merge... 2. Add string "The function ".

PushKK changed the title ~~Viewmanager.py~~ Viewmanager.py: add check disk space May 20, 2021

PushKK and others added 2 commits May 21, 2021 10:50

sqlite3.OperationalError: database or disk is full

b69a963

For https://gramps-project.org/bugs/view.php?id=12306

Update viewmanager.py

a84b0c0

Nick-Hall added the enhancement label May 21, 2021

Nick-Hall requested changes May 21, 2021

View reviewed changes

This was referenced May 21, 2021

sqlite3.OperationalError: database or disk is full #1215

Closed

sqlite3.OperationalError: database or disk is full #2 #1218

Draft

Nick-Hall closed this Mar 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Viewmanager.py: add check disk space #1212

Viewmanager.py: add check disk space #1212

PushKK commented May 20, 2021

tosky commented May 20, 2021

codecov-commenter commented May 20, 2021

PushKK commented May 21, 2021 •

edited

Loading

Nick-Hall commented May 21, 2021

Nick-Hall left a comment

Nick-Hall May 21, 2021

PushKK May 23, 2021

Nick-Hall May 21, 2021

PushKK May 21, 2021

Nick-Hall May 21, 2021

PushKK May 21, 2021 •

edited

Loading

Nick-Hall May 21, 2021

PushKK May 21, 2021

PushKK May 23, 2021

Nick-Hall May 21, 2021

PushKK May 21, 2021

Nick-Hall May 21, 2021

PushKK May 23, 2021 •

edited

Loading

Nick-Hall commented Mar 12, 2022

Nick-Hall commented Mar 12, 2022

Viewmanager.py: add check disk space #1212

Viewmanager.py: add check disk space #1212

Conversation

PushKK commented May 20, 2021

tosky commented May 20, 2021

codecov-commenter commented May 20, 2021

Codecov Report

PushKK commented May 21, 2021 • edited Loading

Nick-Hall commented May 21, 2021

Nick-Hall left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PushKK May 21, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PushKK May 23, 2021 • edited Loading

Choose a reason for hiding this comment

Nick-Hall commented Mar 12, 2022

Nick-Hall commented Mar 12, 2022

PushKK commented May 21, 2021 •

edited

Loading

PushKK May 21, 2021 •

edited

Loading

PushKK May 23, 2021 •

edited

Loading