-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically resolve and index grafting dependencies #439
Comments
Agreed, it'd be worth adding an Regarding UX: do you think indexers would like control over this feature ? In particularly they may want to protect themselves from deep recursion of subgraph deployment dependencies? I'm thinking we could provide either:
|
Makes total sense to me. The whole grafting tree could be resolved (and potentially invalidated against the max resolver depth) before deploying anything to graph-node too :) |
How to handle this problem manually, thank you. |
Hello @jian-guo-s ! The manual solution is to deploy and sync the graft base deployment upto the graft block before deploying the intended deployment. In your case, deployment |
I've just started looking at how to manage these graft dependencies and would like to +1 and bump this as a feature request. After a discussion with ellipfra/Marc-Andre, it would also be really useful to have an option that would also delete the base once the graft copy is completed |
If this is implemented then we don't need the note here: graphprotocol/docs#501 |
+1 to this feature. I also like the idea of it being a number you set for graft depth. It would also be useful if graph-node automatically checked something like 2n or 3n grafts deep so that it could report the number of required grafts in the deployment error (or that it exhausted the max search). And like @cryptovestor21 mentioned, an option to automatically delete graft bases would be much appreciated. |
This feature would be awesome indeed, just had a case where a subgraph depended on other 4 grafts, making it quite time consuming to resolve and index all of them manually. |
Paraphrased feedback on preferred UXVince | Nodeify, InfraDAO, & Pinax
Pseudo code UX sketches
|
When trying to index a subgraph that has a graft base, unless the base is already syncing, indexer-agent shows this error:
graph-node:
The agent could automatically resolve any grafting dependencies and ensure that those are indexing too. This is currently a manual process.
The text was updated successfully, but these errors were encountered: