From b1bbcd17203b7cad13eeed77c4aee937dbd0717a Mon Sep 17 00:00:00 2001
From: Rozaev Viktor <vrozaev@nebius.com>
Date: Fri, 19 Jan 2024 12:50:57 +0100
Subject: [PATCH] feat(Disclosure): added qa attribute for details and summary
 nodes (#1253)

---
 src/components/Disclosure/Disclosure.tsx                  | 2 +-
 .../Disclosure/DisclosureDetails/DisclosureDetails.tsx    | 3 ++-
 .../Disclosure/DisclosureSummary/DisclosureSummary.tsx    | 3 ++-
 src/components/Disclosure/cn.ts                           | 3 ---
 src/components/Disclosure/constants.ts                    | 8 ++++++++
 src/components/Disclosure/index.ts                        | 1 +
 6 files changed, 14 insertions(+), 6 deletions(-)
 delete mode 100644 src/components/Disclosure/cn.ts
 create mode 100644 src/components/Disclosure/constants.ts

diff --git a/src/components/Disclosure/Disclosure.tsx b/src/components/Disclosure/Disclosure.tsx
index 21e7e50802..c7730ecede 100644
--- a/src/components/Disclosure/Disclosure.tsx
+++ b/src/components/Disclosure/Disclosure.tsx
@@ -6,7 +6,7 @@ import {isOfType} from '../utils/isOfType';
 import {DisclosureProvider} from './DisclosureContext';
 import {DisclosureDetails} from './DisclosureDetails/DisclosureDetails';
 import {DefaultDisclosureSummary, DisclosureSummary} from './DisclosureSummary/DisclosureSummary';
-import {b} from './cn';
+import {b} from './constants';
 
 import './Disclosure.scss';
 
diff --git a/src/components/Disclosure/DisclosureDetails/DisclosureDetails.tsx b/src/components/Disclosure/DisclosureDetails/DisclosureDetails.tsx
index c9d7783d92..5d861723a7 100644
--- a/src/components/Disclosure/DisclosureDetails/DisclosureDetails.tsx
+++ b/src/components/Disclosure/DisclosureDetails/DisclosureDetails.tsx
@@ -4,7 +4,7 @@ import {CSSTransition} from 'react-transition-group';
 
 import {getCSSTransitionClassNames} from '../../utils/transition';
 import {useDisclosureAttributes} from '../DisclosureContext';
-import {b} from '../cn';
+import {DisclosureQa, b} from '../constants';
 
 export interface DisclosureDetailsProps {
     children: React.ReactNode;
@@ -30,6 +30,7 @@ export function DisclosureDetails({children}: DisclosureDetailsProps) {
                 role="region"
                 aria-labelledby={ariaLabelledby}
                 className={b('content', {visible: expanded})}
+                data-qa={DisclosureQa.DETAILS}
             >
                 {children}
             </div>
diff --git a/src/components/Disclosure/DisclosureSummary/DisclosureSummary.tsx b/src/components/Disclosure/DisclosureSummary/DisclosureSummary.tsx
index ffc5350e42..acdacae3e2 100644
--- a/src/components/Disclosure/DisclosureSummary/DisclosureSummary.tsx
+++ b/src/components/Disclosure/DisclosureSummary/DisclosureSummary.tsx
@@ -3,7 +3,7 @@ import React from 'react';
 import {ArrowToggle} from '../../ArrowToggle';
 import type {DisclosureSize} from '../Disclosure';
 import {useDisclosureAttributes, useToggleDisclosure} from '../DisclosureContext';
-import {b} from '../cn';
+import {DisclosureQa, b} from '../constants';
 
 const ComponentSizeToIconSizeMap: Record<DisclosureSize, number> = {
     m: 14,
@@ -47,6 +47,7 @@ export function DefaultDisclosureSummary({
             id={id}
             onClick={onClick}
             disabled={disabled}
+            data-qa={DisclosureQa.SUMMARY}
         >
             <ArrowToggle
                 size={ComponentSizeToIconSizeMap[size]}
diff --git a/src/components/Disclosure/cn.ts b/src/components/Disclosure/cn.ts
deleted file mode 100644
index 2866e885b0..0000000000
--- a/src/components/Disclosure/cn.ts
+++ /dev/null
@@ -1,3 +0,0 @@
-import {blockNew} from '../utils/cn';
-
-export const b = blockNew('disclosure');
diff --git a/src/components/Disclosure/constants.ts b/src/components/Disclosure/constants.ts
new file mode 100644
index 0000000000..2febfab7e0
--- /dev/null
+++ b/src/components/Disclosure/constants.ts
@@ -0,0 +1,8 @@
+import {blockNew} from '../utils/cn';
+
+export const b = blockNew('disclosure');
+
+export const DisclosureQa = {
+    SUMMARY: 'disclosure-summary',
+    DETAILS: 'disclosure-details',
+};
diff --git a/src/components/Disclosure/index.ts b/src/components/Disclosure/index.ts
index c9f340669c..4eb5fb09c6 100644
--- a/src/components/Disclosure/index.ts
+++ b/src/components/Disclosure/index.ts
@@ -1,2 +1,3 @@
 export {Disclosure} from './Disclosure';
 export type {DisclosureSize, DisclosureArrowPosition, DisclosureProps} from './Disclosure';
+export {DisclosureQa} from './constants';