Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old version of googles flatbuffers-java included. #4

Open
dajoni opened this issue Oct 11, 2018 · 2 comments
Open

Old version of googles flatbuffers-java included. #4

dajoni opened this issue Oct 11, 2018 · 2 comments

Comments

@dajoni
Copy link

dajoni commented Oct 11, 2018

It should not be the responsibility of a plugin to modify the dependencies of the using project. Or at least make it optional.

@smac89
Copy link
Contributor

smac89 commented Sep 25, 2019

The flatc compiler does not use the version included by this plugin. It goes by the version of the compiler. In my case, I was using flatc compiler version 1.11.0, so I had to download flatbuffer-java version that matches that

@smac89
Copy link
Contributor

smac89 commented Sep 28, 2019

Dear maintainer, the best way to add a dependency from a plugin is to use one of the recommended ways mentioned in this gradle document.

configurations {
    pluginTool {
        defaultDependencies { dependencies ->
            dependencies.add(project.dependencies.create("org.gradle:my-util:1.0"))
        }
    }
}

This way, the user of the plugin can simply add an upgraded version of the dependency without worrying about removing the version added by the plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants