Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:min_confidence not respected #12

Open
jaredmoody opened this issue Jan 17, 2013 · 5 comments
Open

:min_confidence not respected #12

jaredmoody opened this issue Jan 17, 2013 · 5 comments

Comments

@jaredmoody
Copy link

running brakeman -w3 gives me no warnings but guard 'brakeman', :min_confidence => 3 gives me all the errors of just running brakeman

@oreoshake
Copy link

Thanks Jared, will look into it but I think those are inverse values. As in
for w3 you want min_confidence = 0. It should be abstracted to match the
command line args however.

(Mobile, not verified)
On Jan 17, 2013 12:13 PM, "Jared Moody" [email protected] wrote:

running brakeman -w3 gives me no warnings but guard 'brakeman',
:min_confidence => 3 gives me all the errors of brakeman


Reply to this email directly or view it on GitHubhttps://github.com//issues/12.

@presidentbeef
Copy link
Collaborator

@oreoshake is right...this is a horrible mismatch of APIs (and leaking of implementation details) in Brakeman for which I take full blame :(

@jaredmoody
Copy link
Author

Ah, you're right, I was confused. My bad.

@oreoshake
Copy link

I think this should be fixed so I'm reopening.

@oreoshake oreoshake reopened this Jan 18, 2013
@oreoshake
Copy link

Also, w3 == gangster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants