:type appears to be a symbol, not a string

[mikelococo]

Type is documented in several places as being a string:

• notiffany/lib/notiffany/notifier/rb_notifu.rb

  Line 44 in 0618490

  # @option opts [String] type the notification type. Either 'success',

• notiffany/lib/notiffany/notifier/notifysend.rb

  Line 44 in 0618490

  # @option opts [String] type the notification type. Either 'success',

• notiffany/lib/notiffany/notifier/emacs.rb

  Line 56 in 0618490

  # @param [String] type the notification type. Either 'success',

• notiffany/lib/notiffany/notifier/terminal_title.rb

  Line 28 in 0618490

  # @option opts [String] type the notification type. Either 'success',

• notiffany/lib/notiffany/notifier/file.rb

  Line 25 in 0618490

  # @option opts [String] type the notification type. Either 'success',

• notiffany/lib/notiffany/notifier/tmux.rb

  Line 215 in 0618490

  # @option options [String] type the notification type. Either 'success',

• notiffany/lib/notiffany/notifier/libnotify.rb

  Line 32 in 0618490

  # @option opts [String] type the notification type. Either 'success',

• notiffany/lib/notiffany/notifier/terminal_notifier.rb

  Line 36 in 0618490

  # @option opts [String] type the notification type. Either 'success',

• notiffany/lib/notiffany/notifier/gntp.rb

  Line 45 in 0618490

  # @option opts [String] type the notification type. Either 'success',

And sometimes referenced as a string:

notiffany/lib/notiffany/notifier/libnotify.rb

Line 47 in 0618490

urgency: opts[:urgency] || (opts[:type] == "failed" ? :normal : :low)

Whenver I snoop on the values of type, they look like a symbol though. You may wish to update the docs and tweak that libnotify priority switch if they're intended to always be symbols.

[e2]

I'm not that much of a fan of documentation, really. And I don't use notification much, either.

(I'd actually remove the internal documentation, unless it documented something really surprising).

I guess it's intended to be a symbol:

notiffany/lib/notiffany/notifier/base.rb

Line 103 in 0618490

[:failed, :pending, :success].include?(image) ? image : :notify

No one complained yet really, so if you can create a PR, I'll gladly pull it in.

I think the libnotify should be fixed to use fail, so the priority can be shown properly. I think of it as an enhancement, so no compatibility problems here.