Fix most-read.json?_edition=EUR&dcr=true endpoint

[ioannakok]

It is currently broken. It can be hit in the following edge case: A reader

1. Is in the Europe edition
2. Visits an article without a section

dotcom-rendering/dotcom-rendering/src/components/MostViewedFooterData.importable.tsx

Lines 31 to 33 in 2ef128c

	const endpoint = `/most-read${
	hasSection ? `/${sectionId}` : ''
	}.json?_edition=${edition}`;

We haven't found an article yet that does not have a section so this is not likely to affect many readers.

[arelra]

Original post from Mariot:

https://chat.google.com/room/AAAAG9rU0m0/q8w3fX4P1Ao/

[ioannakok]

The issue

https://api.nextgen.guardianapps.co.uk/most-read.json?_edition=EUR&dcr=true endpoint gives a 404 although it seems possible from the DCR code that it can be hit.

Why is this happening?

1. DCR makes a request to https://api.nextgen.guardianapps.co.uk/most-read/[sectionId].json?_edition=EUR&dcr=true
2. When the sectionId is missing from the path the request hits /most-read.json endpoint in onward app.
3. The controller passes the edition to fetch content from the MostPopularAgent.
4. The MostPopularAgent refreshes its cache with most viewed data from CAPI.
5. MostPopularAgent calls CAPI to fetch the content making this query (UK edition example):

https://content.guardianapis.com?show-most-viewed=true&show-elements=all&show-atoms=media&edition=UK&show-rights=syndicatable&show-references=pa-football-competition,pa-football-team,witness-assignment,esa-cricket-match&show-section=true&show-packages=true&show-fields=byline,headline,trail-text,liveBloggingNow,thumbnail,hasStoryPackage,wordcount,shortUrl,commentable,commentCloseDate,starRating,productionOffice&show-tags=all

which redirects to:
https://content.guardianapis.com/uk?show-most-viewed=true&show-elements=all&show-atoms=media&show-rights=syndicatable&show-section=true&show-packages=true&show-fields=byline,headline,trail-text,liveBloggingNow,thumbnail,hasStoryPackage,wordcount,shortUrl,commentable,commentCloseDate,starRating,productionOffice&show-tags=all&show-references=pa-football-competition,pa-football-team,witness-assignment,esa-cricket-match

The CAPI query frontend is making for Europe content is:

https://content.guardianapis.com?show-most-viewed=true&show-elements=all&show-atoms=media&edition=EUR&show-rights=syndicatable&show-references=pa-football-competition,pa-football-team,witness-assignment,esa-cricket-match&show-section=true&show-packages=true&show-fields=byline,headline,trail-text,liveBloggingNow,thumbnail,hasStoryPackage,wordcount,shortUrl,commentable,commentCloseDate,starRating,productionOffice&show-tags=all

Because the Europe id is EUR.

This query does not redirect and returns an empty array, hence the cache is empty for key EUR

Query parameter should be edition=EUROPE instead of edition=EUR:

https://content.guardianapis.com?show-most-viewed=true&show-elements=all&show-atoms=media&edition=EUROPE&show-rights=syndicatable&show-references=pa-football-competition,pa-football-team,witness-assignment,esa-cricket-match&show-section=true&show-packages=true&show-fields=byline,headline,trail-text,liveBloggingNow,thumbnail,hasStoryPackage,wordcount,shortUrl,commentable,commentCloseDate,starRating,productionOffice&show-tags=all

Fixing the query for the Europe edition content populates the agent with content and fixes this endpoint. See for a draft solution:

• Add EditionIdCAPIMapper frontend#26830

What happens currently with the Most Viewed container for articles in the Europe edition?

It seems to be working fine because all articles have a sectionId. I haven't been able to find one without it. When sectionId is present the content is fetched directly from CAPI and onward app does not return the empty content coming from the MostPopularAgent.

[ioannakok]

We noticed that the same issue exists for the International edition. The entry in the cache is empty because frontend is using query parameter edition=INT instead of the correct edition=INTERNATIONAL

https://content.guardianapis.com?show-most-viewed=true&show-elements=all&show-atoms=media&edition=INT&show-rights=syndicatable&show-references=pa-football-competition,pa-football-team,witness-assignment,esa-cricket-match&show-section=true&show-packages=true&show-fields=byline,headline,trail-text,liveBloggingNow,thumbnail,hasStoryPackage,wordcount,shortUrl,commentable,commentCloseDate,starRating,productionOffice&show-tags=all

CAPI returns an empty list.

https://content.guardianapis.com?show-most-viewed=true&show-elements=all&show-atoms=media&edition=INTERNATIONAL&show-rights=syndicatable&show-references=pa-football-competition,pa-football-team,witness-assignment,esa-cricket-match&show-section=true&show-packages=true&show-fields=byline,headline,trail-text,liveBloggingNow,thumbnail,hasStoryPackage,wordcount,shortUrl,commentable,commentCloseDate,starRating,productionOffice&show-tags=all

CAPI returns content.

Draft PR: 26830 that fixes the issue. We need to double check with the CAPI team if this is an appropriate solution.