Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential speed improvement: parallelise 🔒 Read Signing Key Id & 🎊 Test & Version #18

Open
rtyley opened this issue Dec 27, 2023 · 0 comments

Comments

@rtyley
Copy link
Member

rtyley commented Dec 27, 2023

🔒 Read Signing Key Id and 🎊 Test & Version could be parallelised before 🔒 Push Release Commit:

image

🎊 Test & Version doesn't really need to know the GPG key id or email address, though it currently does make some commits, and that needs some email address.

A quick option to fix the issue might be to use a stub email address in 🎊 Test & Version, though we would need to make sure that 🔒 Push Release Commit ends up using the correct committer address if it's cherry-picking those commits from 🎊 Test & Version.

A better option may be to switch from communicating between jobs using bare-git-repo, and instead just have 🎊 Test & Version output just the crucial version number. The subsequent jobs do need to know which file to modify (ie version.sbt), how to construct the version tag (ie, add a v prefix) and also the snapshot version number of the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant