From a340321442068fa344f2f0df3c23f51334020b21 Mon Sep 17 00:00:00 2001
From: Lindsey Dew <1202622+lindseydew@users.noreply.github.com>
Date: Mon, 11 Mar 2024 17:51:10 +0000
Subject: [PATCH] Run tests in CI

---
 .../ci-mobile-save-for-later-user-deletion.yaml  |  3 +++
 .github/workflows/ci-mobile-save-for-later.yaml  |  3 +++
 .../gu/sfl/lib/ArticleMergeSpecification.scala   | 16 ----------------
 3 files changed, 6 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/ci-mobile-save-for-later-user-deletion.yaml b/.github/workflows/ci-mobile-save-for-later-user-deletion.yaml
index 7cb23581..217fc8f2 100644
--- a/.github/workflows/ci-mobile-save-for-later-user-deletion.yaml
+++ b/.github/workflows/ci-mobile-save-for-later-user-deletion.yaml
@@ -20,6 +20,9 @@ jobs:
           distribution: temurin
           cache: sbt
 
+      - name: Run Tests
+        run: sbt "project mobile-save-for-later-user-deletion" test
+
       - name: Create artifacts
         run: sbt "project mobile-save-for-later-user-deletion" assembly
 
diff --git a/.github/workflows/ci-mobile-save-for-later.yaml b/.github/workflows/ci-mobile-save-for-later.yaml
index c3a57bdf..b5a1d10a 100644
--- a/.github/workflows/ci-mobile-save-for-later.yaml
+++ b/.github/workflows/ci-mobile-save-for-later.yaml
@@ -20,6 +20,9 @@ jobs:
           distribution: corretto
           cache: sbt
 
+      - name: Run Tests
+        run: sbt "project mobile-save-for-later" test
+
       - name: Create artifacts
         run: sbt "project mobile-save-for-later" assembly
 
diff --git a/mobile-save-for-later/src/test/scala/com/gu/sfl/lib/ArticleMergeSpecification.scala b/mobile-save-for-later/src/test/scala/com/gu/sfl/lib/ArticleMergeSpecification.scala
index ee6e35a0..29767473 100644
--- a/mobile-save-for-later/src/test/scala/com/gu/sfl/lib/ArticleMergeSpecification.scala
+++ b/mobile-save-for-later/src/test/scala/com/gu/sfl/lib/ArticleMergeSpecification.scala
@@ -91,10 +91,6 @@ class ArticleMergeSpecification extends Specification with Mockito {
       val saved =
         savedArticlesMerger.updateWithRetryAndMerge(userId, savedArticles2)
       there was one(savedArticlesPersistence).read(argThat(===(userId)))
-      there were no(savedArticlesPersistence).write(
-        any[String](),
-        any[SavedArticles]()
-      )
       there was one(savedArticlesPersistence).update(
         argThat(===(userId)),
         argThat(===(savedArticles2))
@@ -110,10 +106,6 @@ class ArticleMergeSpecification extends Specification with Mockito {
       val saved =
         savedArticlesMerger.updateWithRetryAndMerge(userId, savedArticles)
       there was one(savedArticlesPersistence).read(argThat(===(userId)))
-      there were no(savedArticlesPersistence).write(
-        any[String](),
-        any[SavedArticles]()
-      )
       there were no(savedArticlesPersistence).update(
         any[String](),
         any[SavedArticles]()
@@ -185,10 +177,6 @@ class ArticleMergeSpecification extends Specification with Mockito {
       val saved =
         savedArticlesMerger.updateWithRetryAndMerge(userId, savedArticles2)
 
-      there were no(savedArticlesPersistence).write(
-        any[String](),
-        any[SavedArticles]()
-      )
       there was one(savedArticlesPersistence).update(
         argThat(===(userId)),
         argThat(===(expectedArticlesPersisted))
@@ -222,10 +210,6 @@ class ArticleMergeSpecification extends Specification with Mockito {
       ) returns (Success(Some(expectedArticlesPersisted.advanceVersion)))
       val saved =
         savedArticlesMerger.updateWithRetryAndMerge(userId, articlesToSave)
-      there were no(savedArticlesPersistence).write(
-        any[String](),
-        any[SavedArticles]()
-      )
       there was one(savedArticlesPersistence).update(
         argThat(===(userId)),
         argThat(===(expectedArticlesPersisted))