Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add an allow_fail option #62

Open
1 task done
gdubicki opened this issue May 29, 2024 · 0 comments
Open
1 task done

Please add an allow_fail option #62

gdubicki opened this issue May 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@gdubicki
Copy link

gdubicki commented May 29, 2024

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Describe the problem imposed by not having this feature

Sometimes we merge a PR without waiting for its CircleCI workflow to complete. When we merge, we delete the source branch. Then the subsequent job in that workflow fails on the git-shallow-clone/checkout step because the branch doesn't exist...

We would like to have a solution to prevent such workflows from spoiling our CI statistics.

Describe the solution you'd like

I propose to add an allow_fail option, set to false by default. If set to true, then the whole step would exit with code 0 even if anything would go wrong in it.

We would set it for our non-critical jobs, such as sending test coverage info to our coverage server.

@gdubicki gdubicki added the enhancement New feature or request label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant