Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero-size Hotp window #42

Open
batrudinych opened this issue Aug 3, 2016 · 1 comment
Open

Zero-size Hotp window #42

batrudinych opened this issue Aug 3, 2016 · 1 comment

Comments

@batrudinych
Copy link

For now I can't pass 0 as window size because of that check: var window = opt.window || 50;
I assume that comparing with umdefined should be performed in spite of the notp library is kind of low-level one.
See the PR #41.

@guyht
Copy link
Owner

guyht commented Sep 23, 2016

Got your PR, and while its a bit of an edge case it does make sense so will merge. I dont recommend setting it to 0 as it will require tight sync for your app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants