Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary allocation for views which store sub/upp-diagonal data for tridiagonal solver #43

Open
AbdelhadiKara opened this issue Jan 17, 2025 · 0 comments

Comments

@AbdelhadiKara
Copy link
Collaborator

Please mention something about the expected sizes here. Especially in places where the size is not intuitive. E.g. by default I would expect :

  • AA to have size block_size x (n_diags-1),
  • BB to have size block_size x n_diags,
  • CC to have size block_size x (n_diags-1)

But looking at the later code it seems that this is not the convention is chosen. It is therefore important to document the expected contents and position of the additional 2*block_size elements.

It would be good to remove these extra elements (imagine how much extra data is required if we solve in 5D space) but this should be done in a later MR and is not a priority atm as we don't currently need this solver for the 5D case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant