You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please mention something about the expected sizes here. Especially in places where the size is not intuitive. E.g. by default I would expect :
AA to have size block_size x (n_diags-1),
BB to have size block_size x n_diags,
CC to have size block_size x (n_diags-1)
But looking at the later code it seems that this is not the convention is chosen. It is therefore important to document the expected contents and position of the additional 2*block_size elements.
It would be good to remove these extra elements (imagine how much extra data is required if we solve in 5D space) but this should be done in a later MR and is not a priority atm as we don't currently need this solver for the 5D case.
The text was updated successfully, but these errors were encountered:
Please mention something about the expected sizes here. Especially in places where the size is not intuitive. E.g. by default I would expect :
But looking at the later code it seems that this is not the convention is chosen. It is therefore important to document the expected contents and position of the additional 2*block_size elements.
It would be good to remove these extra elements (imagine how much extra data is required if we solve in 5D space) but this should be done in a later MR and is not a priority atm as we don't currently need this solver for the 5D case.
The text was updated successfully, but these errors were encountered: