Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt EdgeTransformation operator to Tjoint. #61

Open
PaulineVidal opened this issue Jan 17, 2025 · 0 comments
Open

Adapt EdgeTransformation operator to Tjoint. #61

PaulineVidal opened this issue Jan 17, 2025 · 0 comments

Comments

@PaulineVidal
Copy link
Collaborator

For the computation of the equivalent coordinate, does not consider the T-joint case. It also affects the other operators.

Currently we deal with logical domains whose coordinates don't especially fit together so we rescale the coordinates:

  • Eg: [a1, b1] sticks with [a2, b2] so a coordinate c1 on the patch 2 is computed with c2 = (c1 - a1) / (b1 - a1) * (b2 - a2).
 a1 || a2
 ||
 ||
 b1 || b2

But it doesnt work with T-joint.

 a1 || a2
 ||
 ||
 b1 || 
 |
 |b2

One solution is to consider that we always have (value of a1 = value of a2) and (value of b1 = value of b2). Which will be the most frequent case.

Another solution, more general, is to add the mapping(s) to the physical domain as input and work with it. It might be pretty difficult to identify if a coordinate is before or after the T-joint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant