Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify instance with user id instead of username #230

Open
pixtron opened this issue Jan 27, 2020 · 1 comment
Open

Identify instance with user id instead of username #230

pixtron opened this issue Jan 27, 2020 · 1 comment

Comments

@pixtron
Copy link
Member

pixtron commented Jan 27, 2020

Describe the bug

Currently an instance is identified by server, username and context. If the username changes an existing instance would not be found anymore.

To Reproduce

1.) Login with user A
2.) Logout and login with user B
3.) Change username of user A
4.) Logout and login again with user A

Expected behavior

Existing instance for user A should be loaded.

Environment

  • desktop client version: v1.2.1

Additional context

Add any other context about the problem here.

@pixtron pixtron added the bug label Jan 27, 2020
@pixtron pixtron added this to the 1.3.x milestone Jan 27, 2020
@pixtron
Copy link
Member Author

pixtron commented Jan 27, 2020

For migration reasons, we would need to keep the existing check for a while, to handle cases where an instance does not yet have the userId set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant