Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve ignored_columns vs included_columns on model builders #13139

Closed
exalate-issue-sync bot opened this issue May 13, 2023 · 3 comments
Closed

Resolve ignored_columns vs included_columns on model builders #13139

exalate-issue-sync bot opened this issue May 13, 2023 · 3 comments

Comments

@exalate-issue-sync
Copy link

Should ignored_columns on all the model builders be changed to included_columns?

cc [~accountid:557058:abbecef9-9266-49cd-a13f-d0c5d27cb5da], [~accountid:557058:1529d34e-fbf0-45b1-8f33-facc04ecb672]

@exalate-issue-sync
Copy link
Author

Cliff Click commented: Minor tweak to the API - general philosophy is to choose positive over negatives. So yes, included is better than excluded, even if the included-list is likely to be large all the time.

@exalate-issue-sync
Copy link
Author

Raymond Peck commented: I talked with Patrick about this the other day, and my proposal was to allow the client to specify either the included or the excluded (error out if they specify both), and always convert that in the REST API layer to the current ignored_columns mechanism.

@hasithjp
Copy link
Member

JIRA Issue Migration Info

Jira Issue: PUBDEV-123
Assignee: Raymond Peck
Reporter: Prithvi Prabhu
State: Resolved
Fix Version: N/A
Attachments: N/A
Development PRs: Available

Linked PRs from JIRA

#5352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant