-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression from earlier version, inline Buttons are misplaced #2361
Comments
This behavior was introduced by #2273. As a temporary solution you can wrap buttons with from h2o_wave import main, app, Q, ui
@app('/demo')
async def serve(q: Q):
q.page['example'] = ui.form_card(
box='1 1 -1 4',
items=[
ui.inline(
[ui.buttons([
ui.button(
name="b1",
label="Button1",
primary=False,
width="150px",
),
ui.button(
name="b2",
label="Button2",
primary=False,
width="150px",
),
ui.button(
name="b3",
label="Button3",
primary=True,
width="200px",
),
ui.button(
name="b4",
label="Button4",
primary=False,
width="200px",
)
])],
justify="start",
),
]
)
await q.page.save() ![]() |
The issue is caused by standalone button having buttons group styles applied which conflicts with styles applied by #2273. XStandAloneButton = ({ model: m }: { model: Button }) => (
<div className={css.buttons}>
<XButton key={m.name} model={m} />
</div>
), Other components should not be affected. |
Thank you @marek-mihok! The quick fix with wrapping the single buttons in a |
marek-mihok
added a commit
that referenced
this issue
Sep 12, 2024
5 tasks
mturoci
pushed a commit
that referenced
this issue
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Wave SDK Version, OS
Wave v1.3.4
Actual behavior
From wave v1.0.0 to wave v1.3.4 the placement of buttons has regressed.
v1.3.4
![image](https://private-user-images.githubusercontent.com/1069138/344978451-8272776a-acd4-451d-87b9-4f774b6224f7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4OTIxMTcsIm5iZiI6MTczODg5MTgxNywicGF0aCI6Ii8xMDY5MTM4LzM0NDk3ODQ1MS04MjcyNzc2YS1hY2Q0LTQ1MWQtODdiOS00Zjc3NGI2MjI0ZjcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDdUMDEzMDE3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWZiN2EzMzNkOGY0MjY1OWJjOGUxOWEyYWI0NTNmZDBjYzkxMzg1OTE2ODlkY2Q2ZGQ2NmQwMmY2NmVlMjI3YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.EyR8HAz9vFIZqNDPKILKK7h9DfcM3y11uCIKiThATHM)
Expected behavior
v1.0.0
![image](https://private-user-images.githubusercontent.com/1069138/344979283-9a4878d1-687a-4339-9833-e43e28d7bec3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4OTIxMTcsIm5iZiI6MTczODg5MTgxNywicGF0aCI6Ii8xMDY5MTM4LzM0NDk3OTI4My05YTQ4NzhkMS02ODdhLTQzMzktOTgzMy1lNDNlMjhkN2JlYzMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDdUMDEzMDE3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDk2ZWRmODM3ZGMyZjhjYmNjOWMzMGVhNGIyZmFlZDk5MzM1MTZmMWIzMmRlYmM5MzZlZmFlYzA4YTViN2U5YSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.XsaQmfRrcCXsRaSRADpnIOlYysX--CyV1OyyPPyMkTc)
The text was updated successfully, but these errors were encountered: