Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Dictionary for door ids in hardware.py is brittle. This should be an enum that maps the pins #14

Open
theTechnoWeenie opened this issue Nov 18, 2014 · 3 comments
Open

Dictionary for door ids in hardware.py is brittle. This should be an enum that maps the pins #14

theTechnoWeenie opened this issue Nov 18, 2014 · 3 comments
Labels
1 - Ready

Comments

@theTechnoWeenie
Copy link
Member

No description provided.

@theTechnoWeenie theTechnoWeenie changed the title Dictionary for door ids is brittle. This should be an enum that maps the pins Dictionary for door ids in hardware.py is brittle. This should be an enum that maps the pins Nov 18, 2014
@icbat
Copy link
Member

icbat commented Nov 18, 2014

Should think of a way to unify it for hardware and service. Maybe just read out of the settings file?

@theTechnoWeenie
Copy link
Member Author

Having them be usable in both is a great idea. We could just capture them in another class that implements enum that is imported into both as well.

@icbat
Copy link
Member

icbat commented Nov 19, 2014

👍 I like that plan. I was leaning toward a class as I was thinking about it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
1 - Ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icbat @theTechnoWeenie