Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Clear Page button does not function on Page 3 #2065

Open
4 tasks
thetanmancan opened this issue Jan 26, 2025 · 1 comment
Open
4 tasks

Bug: Clear Page button does not function on Page 3 #2065

thetanmancan opened this issue Jan 26, 2025 · 1 comment
Assignees
Labels
bug Release Note: Shows as Error Correction level: easy p-feature: Target Points Page p3 Users enter number of parking spaces /calculation/3 priority: MUST HAVE ready for prioritization Issues that are ready to be prioritized by product role: back-end Node/Express Development Task size: 1pt Can be done in 4-6 hours
Milestone

Comments

@thetanmancan
Copy link
Member

thetanmancan commented Jan 26, 2025

Description

On Page 3, when the user clicks the Clear Page button, it should clear data entered in the Parking Provided field. However, in the Dev site, it does not.

Note that this defect is a result of #1993.

Steps to Reproduce

  1. Log into the TDM Dev site.
  2. Navigate to Create Project Page 1.
  3. Enter any valid data in all the required fields.
  4. Click the ">" button.
  5. In the Condominium Units field, enter "16".
  6. In the "Non-Condominium Units with less than 3 habitable rooms" field, enter "1".
  7. In the "Non-Condominium Units with 3 habitable rooms" field, enter "9".
  8. Click the ">" button.
  9. In the Parking Provided field, enter any valid number.
  10. Click the Clear Page button.

Expected Result

The number entered in Step 9 should be cleared from the Parking Provided field.

Actual Result

The number entered in Step 9 remains in the Parking Provided field.

Clear Page does not function
Screen.Recording.2025-01-25.181832.mp4

Device Configuration

  • Device: Desktop
  • OS version: Windows 11
  • Browser: Firefox
  • Browser version: 134.0.2

Action Items

  • Fix bug.
  • Review with product, design, development, and research. Update if needed based on feedback.
  • Once finalized, add Before and After images to the the staging deck.
  • Get Stakeholder sign-off via the stakeholder meeting slide deck.
@roslynwythe
Copy link
Member

roslynwythe commented Jan 30, 2025

Progress
In my local branch, I believe that the handler for the Clear button on Page 3 is now properly configured, because I can see from the debugger that onUncheckAll runs in response to clicking Clear, and if there is a value entered for the "parking spaces provided" input, it will be set to null in updateInputs, and the formInputs object appears to be properly updated, however it does not appear that the ProjectTargetPoints component correctly rerenders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release Note: Shows as Error Correction level: easy p-feature: Target Points Page p3 Users enter number of parking spaces /calculation/3 priority: MUST HAVE ready for prioritization Issues that are ready to be prioritized by product role: back-end Node/Express Development Task size: 1pt Can be done in 4-6 hours
Projects
Status: New Issue Approval
Development

No branches or pull requests

3 participants