Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hail.linalg.BlockMatrix/persist does not work #14689

Open
ehigham opened this issue Sep 17, 2024 · 1 comment
Open

hail.linalg.BlockMatrix/persist does not work #14689

ehigham opened this issue Sep 17, 2024 · 1 comment
Assignees
Labels

Comments

@ehigham
Copy link
Member

ehigham commented Sep 17, 2024

What happened?

cc8d364 refactored the plumbing around (un)persist for Table, MatrixTable and BlockMatrix.
It had the slightly undesirable effect of breaking persist on BlockMatrix.

Version

0.2.114

Relevant log output

No response

@ehigham ehigham added needs-triage A brand new issue that needs triaging. query labels Sep 17, 2024
@patrick-schultz patrick-schultz self-assigned this Sep 23, 2024
@patrick-schultz patrick-schultz removed the needs-triage A brand new issue that needs triaging. label Sep 23, 2024
@patrick-schultz
Copy link
Collaborator

Lets discuss in a team meeting soon

chrisvittal pushed a commit to chrisvittal/hail that referenced this issue Feb 5, 2025
)

This change is split out from a larger refactoring effort on the various
Backend
implementations. The goals of this effort are to provide query-level
configuration to the backend that's currently tied to the lifetime of a
backend,
reduce code duplication and reduce state duplication.

In this change, I'm removing blockmatrix persist/unpersist from the
`Backend`
interface by adding `BlockMatrixCache: mutable.Map[String, BlockMatrix]`
to
`ExecuteContext`. The various reader/writer implementations simply fetch
the
block matrix from this cache. For the spark backend, this is backed by a
cache
whose lifetime is tied to the spark backend. Since block matrices are
not
supported in the local and service backends, the cache is an empty map.

Note that block matrix persist is broken in python (hail-is#14689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants