vkdt-rawler-0.7.99-295-g4f232ddc-win64 used characterset for input causes errors

[Heddesdorfer]

if the filename contains characters like ü, í,... causes
crash if file is an image (e.g. J12A0626ü.CR3 causes crash, J12A0626.CR3 does not)
not loading if file is a movie (e.g. Folías & Romanescas - Mit Jordi Savall.mp4 causes error, Folias & Romanescas - Mit Jordi Savall.mp4 does not)

[hanatos]

(maybe create one issue per issue, if that makes sense ;) )

not sure about the umlaut/special character issue. windows has super strange character encodings that i will never understand. also i can't type > 0x7f on my keyboard so i'm unsure how i can fix this.

what about the mp4 issue? i mean there's so many video formats in the wild that i probably don't want to support them (but mainly the ones that come from cameras). did not understand the above text (does the file work or not work or what?). also, is there any more information about it, maybe on the vkdt console output or by ffprobe? or maybe if that is a publicly available file you have a link for me so i can try to reproduce locally? i'm probably fine with some error, but it shouldn't crash or similar.

[Heddesdorfer]

sorry, i've been a bit deranged after two hours karnevalsumzug....it's been the first one i watched since the early 80s.

the files (cr3 resp. video downloads from mediathekview) are correct, they could be opened without special chracters.
the difference, if the filename contained a special character, was: if it was an image, vkdt crashed without any further output, if it was an mp4, the bomb was displayed.

[hanatos]

ah i see thanks for the clarification. will try to reproduce this..

…

On Wed, Feb 14, 2024 at 2:17 PM Heddesdorfer ***@***.***> wrote: sorry, i've been a bit deranged after two hours karnevalsumzug....it's been the first one i watched since the early 80s. the files (cr3 resp. video downloads from mediathekview) are correct, they could be opened without special chracters. the difference, if the filename contained a special character, was: if it was an image, vkdt crashed without any further output, if it was an mp4, the bomb was displayed. — Reply to this email directly, view it on GitHub <#119 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMAKKPPQ52OO2UUTZSZN33YTS2QFAVCNFSM6AAAAABDG7MEFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBTG42TCMBXHA> . You are receiving this because you commented.Message ID: ***@***.***>

[kmilos]

windows has super strange character encodings that i will never understand.

You can force vkdt to be like a regular UTF-8 app on Windows so you don't need to do any special I/O wide char encoding handling, but it requires building in UCRT64 (I guess you already do?), and minimum Windows 10 1903 for users (which I guess is an ok expectation for a modern app). All you need is add a minimal .rc resource and a manifest file that gets compiled w/ windres (handled automatically by CMake). See e.g. Exiv2/exiv2#2951 and darktable-org/darktable#15899