dns: catch and log root server plugin middleware errors

handshake-org · Feb 18, 2021 · aeddc56 · aeddc56
1 parent 3852599
commit aeddc56
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/lib/dns/server.js b/lib/dns/server.js
@@ -334,7 +334,15 @@ class RootServer extends DNSServer {
     // is able to return an authoritative (non-referral) answer.
     let data = null;
     if (typeof this.middle === 'function') {
-      data = await this.middle(tld, req);
+      try {
+        data = await this.middle(tld, req);
+      } catch (e) {
+        this.logger.error(
+          'Root server middleware resolution failed for name %s: %s',
+          name,
+          e.message
+        );
+      }
 
       // Middleware function did an entire lookup on its own.
       // Despite the variable name this must be a `Message` object,