Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate private channels and guilds / guild channels #96

Open
ghost opened this issue Feb 23, 2022 · 2 comments · Fixed by #97 · May be fixed by #90
Open

separate private channels and guilds / guild channels #96

ghost opened this issue Feb 23, 2022 · 2 comments · Fixed by #97 · May be fixed by #90
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Feb 23, 2022

currently, a "direct message channel" or "private channel" is a type of guild that contains a single channel. because of the simplicity of private channels as compared to full-on channels or guilds, I suggest a new PrivateChannel type:

// PrivateChannel is a private channel between a list of users, independent of a guild.
// It should be possible to use this channel for both text and voice communications.
message PrivateChannel {
  // The list of users that have access to this channel.
  repeated uint64 members = 1;
  // Whether it is possible to add or remove users to/from this channel.
  bool is_locked = 2;
}

(note that fully private, or "direct message", channels, have the is_locked type set - it is not possible to add more users to a DM between two users.)

@ghost ghost added the enhancement New feature or request label Feb 23, 2022
@ghost
Copy link
Author

ghost commented Feb 23, 2022

this also removes guild types, as they are now unneeded

@bluskript
Copy link
Member

the behavior should be that only one PrivateChannel can exist between two users with is_locked set to true. Any number of PrivateChannels can be made that are not locked.

@ghost ghost linked a pull request Feb 23, 2022 that will close this issue
@yusdacra yusdacra linked a pull request Apr 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant