-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Vault KV subkeys to avoid consul-template adding /data/ to the path #2016
base: main
Are you sure you want to change the base?
Conversation
Hi @sofixa, couple of test cases are failing in TestShimKVv2Path. Could you please take a look at it? |
Hi @sreeram77 , I can't test locally because there is no documentation on how to do that. It just vaguely says "install Nomad, Consul, Vault"... which I have, and am running locally. I get this when running the tests:
Which isn't a very helpful. How can I actually run this locally to be able to debug the failing test / my failing code? |
Hi @sofixa |
What's the setup I need for Consul? Any test I try to run, it tries to start the Consul server via consul/sdk/testutil, but fails at https://github.com/hashicorp/consul/blob/4bca5c5d219a7d616f6ae19cca1bc5af913455c3/sdk/testutil/server.go#L467 . How could I even debug this? It doesn't seem related to my Consul setup, because it starts a test server via the SDK directly. Adrian |
Managed to work around the failing Consul dependency by creating a separate file calling the same function and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add support for the Vault KV subkeys API path.
Cf. #2015