-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NET-11798: Set APIGateway TLSConfig if unset or empty #21984
NET-11798: Set APIGateway TLSConfig if unset or empty #21984
Conversation
…nd_CipherSuites_settings_not_respected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a couple of questions
Co-authored-by: Nathan Coleman <[email protected]>
…nd_CipherSuites_settings_not_respected
* NET-11798: Set APIGateway TLSConfig if unset or empty * add changelog * update golden file tests * add missing golden files * Update .changelog/21984.txt Co-authored-by: Nathan Coleman <[email protected]> * remove use of reflect library and check if object is empty instead --------- Co-authored-by: Nathan Coleman <[email protected]>
📣 Hi @NiniOak! a backport is missing for this PR [21984] for versions [1.15,1.18,1.19,1.20] please perform the backport manually and add the following snippet to your backport PR description:
|
…o release/1.20.x (#22076) * backport of commit 30bc9b5 * backport of commit 02efb33 * backport of commit 7045225 * Update 21984.txt * NET-11798: Set APIGateway TLSConfig if unset or empty (#21984) * NET-11798: Set APIGateway TLSConfig if unset or empty * add changelog * update golden file tests * add missing golden files * Update .changelog/21984.txt Co-authored-by: Nathan Coleman <[email protected]> * remove use of reflect library and check if object is empty instead --------- Co-authored-by: Nathan Coleman <[email protected]> * remove unused library --------- Co-authored-by: NiniOak <[email protected]> Co-authored-by: Nathan Coleman <[email protected]>
📣 Hi @NiniOak! a backport is missing for this PR [21984] for versions [1.15,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:
|
📣 Hi @NiniOak! a backport is missing for this PR [21984] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:
|
Description
The API Gateway TLS.{Min,Max}Versions and TLS.CipherSuites settings are not applied to API Gateway Listeners. To fix this:
setAPIGatewayTLSConfig
that handles the logic for setting TLS configuration for APIGatewayTesting & Reproduction steps
Tested manually, as follows:
Using this config file
config.hcl
make dev-build
consul agent -dev -config-file consul.hcl
consul connect envoy -gateway api -service my-gateway -register
curl -s 0:19000/config_dump | grep tls_minimum
"tls_minimum_protocol_version": "TLSv1_3"
Links
PR Checklist