Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt Provisioner #13062

Closed
mpoore opened this issue Jun 19, 2024 · 6 comments
Closed

Salt Provisioner #13062

mpoore opened this issue Jun 19, 2024 · 6 comments
Assignees
Labels
integration-request Request to register new Packer integration stage/accepted Confirmed, and intend to work on. No timeline commitment though.

Comments

@mpoore
Copy link

mpoore commented Jun 19, 2024

Description

The Salt Packer provisioner executes Salt's "masterless" or "local" mode on the guest operating system of the image that Packer is building.
Salt state files that exist on the guest operating system are used to customize the image to meet a defined desired state. This means the Salt Minion package must be installed on the guest operating system. State files can be uploaded from your local build machine (the one running Packer) by this plugin.
https://github.com/mpoore/packer-plugin-salt

Integration Tier

Community

Checklist

  • [ Y ] Has valid metadata.hcl file in plugin repository.
  • [ Y ] Has added integration scripts packer-plugin-scaffolding to plugin repository.
  • [ Y ] Has added top-level integration README.md file to plugin docs directory.
  • [ Y ] All plugins components have one README.md describing their usage.
  • [ Y ] Has a fully synced .web-docs directory ready for publishing to the integrations portal.
@mpoore mpoore added the integration-request Request to register new Packer integration label Jun 19, 2024
@nywilken nywilken added the stage/accepted Confirmed, and intend to work on. No timeline commitment though. label Jun 24, 2024
@nywilken
Copy link
Contributor

Hi @mpoore thanks for opening up this integration requisition. We've had folks interested in an updated Salt Provider. I am glad to see you take over the plugin, thank you.

I took a Quick Look at the documentation for your integration. The main README L33 needs a link to the provisioner page. Specifically

- [salt](https://developer.hashicorp.com/packer/integrations/mpoore/salt/latest/components/provisioner/salt) - The Packer provisioner will transfer Salt state files to the target guest operating system and execute `Salt` to apply the configured desired state.

I also didn't see the action for notifying the upstream Packer documentation API with updates. If you've copied them and I just can see them that's okay. But if you haven't already I suggest you add the notify-integration-* workflows from here to your project repository.

I've opened a PR internally to register your plugin, once that is merged I will circle back and let you know it is okay to run the manual notification job to ingest the first round of plugin docs.

@nywilken nywilken self-assigned this Jun 24, 2024
@mpoore
Copy link
Author

mpoore commented Jun 25, 2024

Hi @nywilken,

Thank you for reviewing this. I've updated the link in the documentation and also added the two workflows required. Let me know if there's anything else that needs attention.

Thank you again!

@nywilken
Copy link
Contributor

Thanks for the quick action @mpoore. The upstream PR to enable the integration has been merged. Can you please trigger a manual notification workflow for your plugin using 0.1.2 as the version and main as the branch.

If the job will notify our API to ingest the plugin docs. It will take about 15 minutes to rebuild and clear the cache but if there are no errors reported all should appear as expected. I'll keep this issue open until we've confirmed the plugin is listed as an integration.

@mpoore
Copy link
Author

mpoore commented Jun 25, 2024

Thank you, @nywilken. That completed successfully. I'll check back in a little while :-)

@nywilken
Copy link
Contributor

Thanks for pushing this integration forward. Closing this issue as the Salt provisioner integration is now live at https://developer.hashicorp.com/packer/integrations/mpoore/salt

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integration-request Request to register new Packer integration stage/accepted Confirmed, and intend to work on. No timeline commitment though.
Projects
None yet
Development

No branches or pull requests

2 participants