Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: valid values of "action" property WAFv2 loggin_configuration mismatched. #40978

Closed
atobaum opened this issue Jan 17, 2025 · 2 comments · Fixed by #40979
Closed

[Docs]: valid values of "action" property WAFv2 loggin_configuration mismatched. #40978

atobaum opened this issue Jan 17, 2025 · 2 comments · Fixed by #40979
Labels
documentation Introduces or discusses updates to documentation. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Milestone

Comments

@atobaum
Copy link
Contributor

atobaum commented Jan 17, 2025

Documentation Link

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/wafv2_web_acl_logging_configuration#action-condition

Description

The document says the valid values of action of action_condition property are ALLOW, BLOCK, and COUNT.
But the provider accepts one of ["ALLOW" "BLOCK" "COUNT" "CAPTCHA" "CHALLENGE" "EXCLUDED_AS_COUNT"].

References

https://docs.aws.amazon.com/waf/latest/APIReference/API_ActionCondition.html
https://github.com/aws/aws-sdk-go-v2/blob/main/service/wafv2/types/enums.go#L8-L15

Would you like to implement a fix?

Yes

@atobaum atobaum added the documentation Introduces or discusses updates to documentation. label Jan 17, 2025
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 17, 2025
@ewbankkit ewbankkit added service/wafv2 Issues and PRs that pertain to the wafv2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 20, 2025
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.85.0 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Projects
None yet
2 participants