Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Support IAM / EC2 auth methods #199

Open
domingogomez-asto opened this issue Mar 22, 2021 · 3 comments
Open

[FEAT] Support IAM / EC2 auth methods #199

domingogomez-asto opened this issue Mar 22, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@domingogomez-asto
Copy link

Is your feature request related to a problem? Please describe.
I have private github runners in AWS that already have an instance profile. Calls to vault should be able to leverage that instance profile role or another assumed role to auth.

Describe the solution you'd like
An additional authentication method in this action code that supports vault AWS auth options.

Describe alternatives you've considered
Use sts assume role and vault cli commands to retrieve the secrets in a bash script.

Additional context
https://www.vaultproject.io/docs/auth/aws

@domingogomez-asto domingogomez-asto added the enhancement New feature or request label Mar 22, 2021
@jasonodonnell
Copy link
Contributor

Thanks @domingogomez-asto, we're looking into adding more Auth Methods. Additionally, if anyone in the community is interested in contributing, we'd be happy to review!

@replicant0wnz
Copy link

Is anyone working on this yet? I was gonna take a stab at it but I never touch js ..

@replicant0wnz
Copy link

Ya, n/m. I thought it was gonna be some simple copypasta as the Vault command line client only needs the role name for IAM auth. It appears to be doing a ton more stuff in the background and after looking at Python examples it's gonna be a tad more complicated. Most likely will require the nodejs SDK for AWS ..

@jasonodonnell Does hashicorp plan on adding AWS IAM auth to this module anytime soon? If not I'm just gonna wrap the Vault client in a Docker action and call it a day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants