We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encodeUtf
decodeUtf
encodeWith and decodeWith use try @SomeException to catch all exceptions that may arise while dealing with C buffers.
encodeWith
decodeWith
try @SomeException
See for instance
os-string/System/OsString/Common.hs
Line 239 in 06a9edc
This is incorrect, as asynchronous exceptions thrown to such code (for instance using killThread or ^C) should not result in a EncodingException.
killThread
^C
EncodingException
The simplest way to fix it is to see if the exception is SomeAsyncException and if so reraise it.
SomeAsyncException
See also https://gitlab.haskell.org/ghc/ghc/-/issues/25479
The text was updated successfully, but these errors were encountered:
Can you provide a PR?
Sorry, something went wrong.
Don't catch asynchronous exceptions
42b0b12
Fixes #22
Don't catch async exceptions
edc9532
Related: haskell/os-string#22
Successfully merging a pull request may close this issue.
encodeWith
anddecodeWith
usetry @SomeException
to catch all exceptions that may arise while dealing with C buffers.See for instance
os-string/System/OsString/Common.hs
Line 239 in 06a9edc
This is incorrect, as asynchronous exceptions thrown to such code (for instance using
killThread
or^C
) should not result in aEncodingException
.The simplest way to fix it is to see if the exception is
SomeAsyncException
and if so reraise it.See also https://gitlab.haskell.org/ghc/ghc/-/issues/25479
The text was updated successfully, but these errors were encountered: