Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic package is not getting uploaded even after release of latest revision #322

Closed
saicharan0112 opened this issue Apr 19, 2023 · 3 comments · Fixed by #323
Closed

Magic package is not getting uploaded even after release of latest revision #322

saicharan0112 opened this issue Apr 19, 2023 · 3 comments · Fixed by #323

Comments

@saicharan0112
Copy link

saicharan0112 commented Apr 19, 2023 •
edited
Loading

I see that conda package version (8.3.389) and the release tag from Magic Github repo (8.3.392) are not in sync. Is there a reason behind it?

cc: @proppy, @msaligane
@proppy
Copy link
Contributor

proppy commented Apr 22, 2023

Looks like the osx build is failing:
https://github.com/hdl/conda-eda/actions/runs/4769548675/jobs/8480013022

@proppy
Copy link
Contributor

proppy commented Apr 22, 2023

/cc @xobs

@proppy
Copy link
Contributor

proppy commented Apr 22, 2023

The following patch https://github.com/hdl/conda-eda/blob/master/misc/magic/rename-region-to-netregion.patch doesn't seems to be needed anymore, since it has been applied upstream:
RTimothyEdwards/magic@1e7da74

xobs added a commit to xobs/conda-eda that referenced this issue Apr 22, 2023
@xobs
magic: remove patch to rename Region
bad1565 
This patch was necessary on osx, and has since been upstreamed.

This fixes hdl#322

Signed-off-by: Sean Cross <[email protected]>
@xobs xobs mentioned this issue Apr 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

magic: remove patch to rename Region xobs/conda-eda
2 participants
@proppy @saicharan0112