Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open_pdks.sky130a package needs to be updated to latest version #329

Closed
michahn01 opened this issue May 15, 2023 · 6 comments · Fixed by #336
Closed

open_pdks.sky130a package needs to be updated to latest version #329

michahn01 opened this issue May 15, 2023 · 6 comments · Fixed by #336
Assignees
@proppy

Comments

@michahn01
Copy link

As of this writing, the latest release of OpenPDKs is v1.0.414 (http://opencircuitdesign.com/open_pdks/history.html#Version%201_0). However, LiteX-Hub only supports v1.0.406 (https://anaconda.org/litex-hub/open_pdks.sky130a).

When OpenPDKs.sky130a v1.0.406 is downloaded via Conda from LiteX-Hub and used with Magic, Netgen, OpenROAD, and Yosys (all downloaded from LiteX-Hub as well), OpenPDKs does not function correctly. However, when OpenPDKs v1.0.414 is installed manually (all else held constant), OpenPDKs works correctly. This issue is related to #idea-fasoc/OpenFASOC/issues/209.

I believe a fix might be to update the version of OpenPDKs on LiteX-Hub to the latest official release, v1.0.414.
@mithro
Copy link
Member

mithro commented May 15, 2023

FYI - @proppy

@proppy
Copy link
Contributor

proppy commented May 15, 2023

See #324

@michahn01
Copy link
Author

See #324

#324 seems to have been resolved. @proppy When could we expect the version of open_pdks.sky130a to be updated?

@proppy
Copy link
Contributor

proppy commented Jun 1, 2023 •
edited
Loading

Looks like the timing test are failing:

**********************************************************************
File "$SRC_DIR/skywater-pdk/scripts/python-skywater-pdk/skywater_pdk/liberty.py", line 68, in __main__.TimingType
Failed example:
    (TimingType.leakage | TimingType.ccsnoise).names()
Expected:
    'basic, ccsnoise, leakage'
Got:
    'basic, leakage'
**********************************************************************
File "$SRC_DIR/skywater-pdk/scripts/python-skywater-pdk/skywater_pdk/liberty.py", line 71, in __main__.TimingType
Failed example:
    TimingType.ccsnoise.names()
Expected:
    'basic, ccsnoise'
Got:
    'basic'
**********************************************************************
1 items had failures:
   2 of  10 in __main__.TimingType
***Test Failed*** 2 failures.

See https://github.com/hdl/conda-eda/actions/runs/5127108900/jobs/9222456787

@proppy
Copy link
Contributor

proppy commented Jun 2, 2023

Seems like the failure is related to python 3.11, as the tests passes with python 3.9 and 3.10:

82 tests in 28 items.
82 passed and 0 failed.
Test passed.

@proppy
Copy link
Contributor

proppy commented Jun 2, 2023

Looks like it's a behavior change in 3.11, see python/cpython#99304

In particular the documentation now states that "only canonical flags are returned during iteration": https://docs.python.org/3/howto/enum.html#flag-and-intflag-minutia:~:text=only%20canonical%20flags%20are%20returned%20during%20iteration%3A

@proppy proppy mentioned this issue Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@proppy proppy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

misc/open_pdks/sky130a: use same python version as CI proppy/conda-eda
3 participants
@proppy @mithro @michahn01