Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare deprecations for HDMF 4.0 #766

Closed
3 tasks done
rly opened this issue Sep 14, 2022 · 2 comments
Closed
3 tasks done

Prepare deprecations for HDMF 4.0 #766

rly opened this issue Sep 14, 2022 · 2 comments
Assignees
Labels
category: enhancement improvements of code or code behavior compatibility: breaking change fixes or enhancements that will break schema compatability priority: low alternative solution already working and/or relevant to only specific user(s)
Milestone

Comments

@rly
Copy link
Contributor

rly commented Sep 14, 2022

What would you like to see added to HDMF?

Code is marked throughout HDMF as deprecated or planned for deprecation, but those deprecations have not actually happened. These should be removed because the code is outdated or untested and it adds a cost to maintain.

  1. hdmf.get_region_slicer
  2. Container.add_child
  3. HDF5IO.copy_file
  4. hdmf/build/map.py

These functions are marked as deprecated but are used by a number of NWB extensions and older versions of PyNWB, so should be maintained for some time:

  1. hdmf.utils.fmt_docval_args
  2. hdmf.utils.call_docval_func

Code coverage will be increased by removing deprecated code. There are also some code that is unused and untested, such as monitor.py, array.py, region.py, and parts of query.py.
See https://app.codecov.io/gh/hdmf-dev/hdmf/tree/dev/src/hdmf

Is your feature request related to a problem?

No response

What solution would you like?

Removed the deprecated code.

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@rly rly added this to the 4.0 milestone Aug 8, 2023
@rly rly added category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) compatibility: breaking change fixes or enhancements that will break schema compatability labels Jan 12, 2024
@mavaylon1 mavaylon1 removed this from the 4.0 milestone Mar 3, 2024
@rly rly added this to the Next Major Release - 4.0 milestone Mar 20, 2024
@mavaylon1
Copy link
Contributor

@rly I think we should check some extensions for call_docval_func.

@rly
Copy link
Contributor Author

rly commented Dec 19, 2024

Fixed by #1198 and #1212 and #1221

HDF5IO.copy_file is kept but we can target its removal in HDMF 5.0.

@rly rly closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior compatibility: breaking change fixes or enhancements that will break schema compatability priority: low alternative solution already working and/or relevant to only specific user(s)
Projects
None yet
Development

No branches or pull requests

2 participants