Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dates and how optional deps are specified and tested #1230

Merged
merged 26 commits into from
Jan 17, 2025
Merged

Update dates and how optional deps are specified and tested #1230

merged 26 commits into from
Jan 17, 2025

Conversation

rly
Copy link
Contributor

@rly rly commented Jan 13, 2025 •
edited
Loading

Motivation

  • Updated copyright dates
  • Created optional dependency groups in pyproject.toml and update GitHub Actions workflows to use those instead of requirements files.
  • Stopped using pinned dependencies in the docs and testing. These are not necessary for library testing, confuse new users and developers, and add maintenance burden. Current dependencies are stable enough that they need not be pinned and users can report the libraries they use.
  • Stopped redundant testing using a conda environment.
  • Adopted changelog format conventions: https://keepachangelog.com/en/1.1.0/

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@rly
Copy link
Contributor Author

rly commented Jan 14, 2025

linkml does not yet support Python 3.13 so we will need to use Python 3.12 to test optional dependencies.

@rly rly marked this pull request as ready for review January 14, 2025 01:08
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.87%. Comparing base (a7a5507) to head (977ddc2).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1230      +/-   ##
==========================================
+ Coverage   90.86%   90.87%   +0.01%     
==========================================
  Files          42       42              
  Lines        9524     9524              
  Branches     2725     1921     -804     
==========================================
+ Hits         8654     8655       +1     
  Misses        576      576              
+ Partials      294      293       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly enabled auto-merge (squash) January 14, 2025 23:09
@rly rly requested a review from mavaylon1 January 14, 2025 23:09
mavaylon1
mavaylon1 reviewed Jan 15, 2025
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
rly
rly commented Jan 16, 2025
View reviewed changes
scripts/check_py_support.py Outdated Show resolved Hide resolved
@rly rly requested a review from mavaylon1 January 16, 2025 21:34
@rly rly added this to the 4.0 milestone Jan 17, 2025
@rly rly merged commit dc51890 into dev Jan 17, 2025
27 checks passed
@rly rly deleted the prepare_4.0 branch January 17, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavaylon1 mavaylon1 mavaylon1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rly @mavaylon1