Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize scss partials organization & naming #30

Open
clhenrick opened this issue Apr 11, 2018 · 0 comments
Open

normalize scss partials organization & naming #30

clhenrick opened this issue Apr 11, 2018 · 0 comments

Comments

@clhenrick
Copy link
Contributor

It's slightly confusing that all of mapd3's JS components are stored under ./src/charts/ but that the scss partials are split into ./src/styles/charts/ and ./src/styles/common/.

For example, the tooltip component is located in src/charts/tooltip.js but the equivalent scss partial is located in src/styles/common/_tooltip.scss.

It's also somewhat unclear why some scss partials are prefixed with an underscore and some are not.

This last point is just a nit-picky thing to me, and feel free to take or leave it, but IMO the point of entry for the scss partials should probably be named main.scss instead of mapd3.scss. The former is more of a standard / convention with scss.

We should clean this up to make it more consistent, it could be confusing to developers who want to contribute to this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant