Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BodyLoc1 and BodyLoc2 as an array in item Type struct #77

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

CarlPoppa1
Copy link

Needed for auto equip as we need to know where an item can be placed

@hectorgimenez
Copy link
Owner

what do you think if instead of using []string we use a custom alias type, similar to what we are doing for Item Locations:

const (
LocationEquipped LocationType = "equipped"
LocationStash LocationType = "stash"
LocationSharedStash LocationType = "shared_stash"
LocationBelt LocationType = "belt"
LocationInventory LocationType = "inventory"
LocationCube LocationType = "cube"
LocationVendor LocationType = "vendor"
LocationGround LocationType = "ground"
LocationSocket LocationType = "socket"
LocationUnknown LocationType = "unknown"
LocationCursor LocationType = "cursor"
)

it will be easier for using constants later instead of literal strings

@CarlPoppa1 CarlPoppa1 marked this pull request as draft February 17, 2025 13:27
@CarlPoppa1
Copy link
Author

what do you think if instead of using []string we use a custom alias type, similar to what we are doing for Item Locations:

const (
LocationEquipped LocationType = "equipped"
LocationStash LocationType = "stash"
LocationSharedStash LocationType = "shared_stash"
LocationBelt LocationType = "belt"
LocationInventory LocationType = "inventory"
LocationCube LocationType = "cube"
LocationVendor LocationType = "vendor"
LocationGround LocationType = "ground"
LocationSocket LocationType = "socket"
LocationUnknown LocationType = "unknown"
LocationCursor LocationType = "cursor"
)

it will be easier for using constants later instead of literal strings

I'll do that, thanks

@CarlPoppa1 CarlPoppa1 marked this pull request as ready for review February 19, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants