Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update leveling_tools.go to add new allocation of stats and skills #674

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Wamlad
Copy link

@Wamlad Wamlad commented Feb 9, 2025

Stat and Skill point allocation updated for leveling characters, when the leveling script option is also set.
Stats are done per the d2go order of STR, ENG, DEX and VIT. Which should work well for leveling, reaching gear requirements and mana needs first.
Skills are allocated by comparing totals at the current char level. So it's not just allocating skill X at level Y. It takes into account what you've already skilled up.

Testing:

  • Tested across characters (sorc & paladin leveling scripts)
  • Tested on standard vs. legacy graphics.
  • Tested at different char levels, with different stat settings including changing the order, including 0's, ommissions of certain stats.

Things to note:

  • Several imports (math, slices, sort, strings) were needed to take character config inputs and manipulate them. I have no idea how inefficient this is, but I used them to turn the character settings into usable data in the for loops, no matter the char level, char settings order, ommissions etc.

I'm not a seasoned coder, so would appreciate feedback in making future PRs easy for you devs.
Also appreciate the leveling process in general isn't the main priority but I will be working away at pieces that I use.
This PR solves issue #640

C-Mcp and others added 2 commits February 9, 2025 20:29
Stat and Skill allocation updated for leveling characters.
Stats are done per order in character config, so that can be set independently for gear req. first vs. survivability first (i.e. Str first vs. Vit first).
Skills are allocated by comparing totals at the current char level. So it's not just allocating skill X at level Y. It takes into account what you've already skilled up.
@Antizerg
Copy link

The stat and skill assignment is working nicely, but the current code has us putting only into vita until level 20. We need to put some into strength asap so we can equip gear. I recommend at least 34 strength so we can wear a large shield for eventual Ancients Pledge.

@Wamlad
Copy link
Author

Wamlad commented Feb 16, 2025

Thanks for testing, and agreed re: strength. I’ve intentionally not amended any of the character scripts though whilst making this compatible. They can be class specific and people can amend their own. Theirs separate work being done on auto level/auto equip also, so that’s separate from this PR.

@Antizerg
Copy link

Thanks for testing, and agreed re: strength. I’ve intentionally not amended any of the character scripts though whilst making this compatible. They can be class specific and people can amend their own. Theirs separate work being done on auto level/auto equip also, so that’s separate from this PR.

Good point, I forgot the stat allocation is happening in the specific character go files.

@Wamlad Wamlad mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants