Enable/Repair game.ShiftKey ( shift + left click ) #684
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr enable Shift Key usage. ctx.HID.ClickWithModifier(game.LeftButton, screenPos.X, screenPos.Y, game.ShiftKey) Used for Equipping gear or moving back potions to belt in correct order if we died. Assembly code that returns -32768 (0x8000) for shift key only sets rax to 0x8000 if the key matches,otherwise it returns 0 (due to the initial xor). starts by zeroing rax, which provides a default "key not pressed" state. use single-byte comparisons Original code would always return 0x8000 after doing the comparison, which explains why the modifier behavior wasn't working correctly . It was reporting the key as pressed regardless of which key was being queried.
|
OoooOo I'll put that in the baalrun xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr enable Shift Key usage.
ctx.HID.ClickWithModifier(game.LeftButton, screenPos.X, screenPos.Y, game.ShiftKey)
Used for Equipping items or moving back potions from inventory to Belt in correct order if we died.
Original code would always return 0x8000 after doing the comparison, which explains why the modifier behavior wasn't working correctly . It was reporting the key as pressed regardless of which key was being queried.