Reduce CPU usage (RefreshGameData) #702
Open
+19
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow one RefreshGameData at a time even if requested by multiple places in code. ctx.RefreshGameData() : Performs an immediate refresh if it's been more than 10ms since the last one ctx.RefreshRequest : Signals the background goroutine to reset its timer when it receives a request The background goroutine continues with the regular 100ms refresh cycle that adapt to RefreshRequests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow one RefreshGameData at a time even if requested by multiple places in code.
ctx.RefreshGameData() : Performs an immediate refresh if it's been more than 20ms since the last one
ctx.RefreshRequest : Signals the background goroutine to reset its timer when it receives a request
The background goroutine continues with the regular 100ms refresh cycle that adapt to RefreshRequest
this is to be used with : #701
dont use before the other pr is merged and finished
this also can be paired with hectorgimenez/d2go#83 for optimal reduction