Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-18808 Fix the bug of wrong logging output when keyword is used as identifier in HqlParser.g4 #9198

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

NathanQingyangXu
Copy link
Contributor

https://hibernate.atlassian.net/browse/HHH-18808

Not sure why not move the keyword list into HqlLexer.g4, which would simplify a lot and I think we could still overwrite HqlLexer class. But here is a quick and effective bug fix.

@gavinking
Copy link
Member

I think we should simply remove that log message. It's not useful, IMO.

@NathanQingyangXu
Copy link
Contributor Author

I think we should simply remove that log message. It's not useful, IMO.

If so, we could end up with lots of simplification to the ANTLR grammer, code or even perf.

@gavinking
Copy link
Member

I think we should simply remove that log message. It's not useful, IMO.

If so, we could end up with lots of simplification to the ANTLR grammer, code or even perf.

WDYM?

@gavinking
Copy link
Member

Other than that it looks good.

@NathanQingyangXu
Copy link
Contributor Author

I think we should simply remove that log message. It's not useful, IMO.

If so, we could end up with lots of simplification to the ANTLR grammer, code or even perf.

WDYM?

nvm. I misunderstood. I'd thought we could move the keyword list to lexer file then I found it doesn't work.

Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NathanQingyangXu Please squash the commits and then we are good to go. Thanks!

@gavinking gavinking merged commit 3153bce into hibernate:main Nov 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants