Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateless reactive insert doesn't return the id #2010

Open
DavideD opened this issue Nov 7, 2024 · 1 comment
Open

Stateless reactive insert doesn't return the id #2010

DavideD opened this issue Nov 7, 2024 · 1 comment

Comments

@DavideD
Copy link
Member

DavideD commented Nov 7, 2024

Hibernate ORM stateless insert returns the id:

Object insert(String entityName, Object entity);

The one in Hibernate Reactive should return CompletionStage<Object> but returns CompletionStage<Void>.
Same for Mutiny.

The upgrade to ORM 7 seems a good place to apply these changes.

@gavinking Was this a design choice or something that changed over time?

@gavinking
Copy link
Member

Um, TBH I don't really recall, but I don't think it's essential. You can always just get the id from the entity itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants