Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Permissions Selection UI + Add UPDATE_POLL (allow voting on polls) Permission #10009

Open
timolegros opened this issue Nov 21, 2024 · 2 comments · May be fixed by #10128
Open

Update Permissions Selection UI + Add UPDATE_POLL (allow voting on polls) Permission #10009

timolegros opened this issue Nov 21, 2024 · 2 comments · May be fixed by #10128
Assignees
@salman-neslit
Labels
3 Full day task enhancement New feature or request
Milestone
groups and admin ...

Comments

@timolegros
Copy link
Collaborator

timolegros commented Nov 21, 2024 •
edited by dillchen
Loading

Description

Part 1

Current topic permissions UI:
image

This dropdown/form does not allow for custom combinations of permissions. It also does not scale well as we increase the number of selectable permissions e.g. can't do part 2.

  • Behavior (user should be able to select a topic that adds gating)
  • From there it should be populated into the table and allow users toggle the various permissions
image

https://www.figma.com/design/dGPiswtnIfQIzSNOlB4MNC/Sticky-editor-%2B-Sidebar-%2B-Thread-UI?node-id=1206-4271&t=smMMeNIYRrRIRONf-4

Part 2

Add voting on polls (UPDATE_POLL) as a permission option. This is the correct long-term fix for #9986.

Additional context

@dillchen
@dillchen dillchen added this to the groups and admin update milestone Nov 21, 2024
@dillchen dillchen assigned salman-neslit and unassigned timolegros Nov 21, 2024
@salman-neslit
Copy link
Collaborator

@dillchen @timolegros

  1. UPDATE_POLL has no permission toggle, should i add this as a toggle here?
  2. "can author" and "can post" seems to point at the same thing, should i remove one of them.

@dillchen
Copy link
Contributor

dillchen commented Dec 3, 2024

  1. Add the Poll Option -- call it "use polls"
  2. Create Threads and Create comments should be the options, we shouldn't have create posts, correct

@salman-neslit salman-neslit linked a pull request Dec 4, 2024 that will close this issue
Open
@dillchen dillchen added 3 Full day task and removed needs estimate labels Dec 5, 2024
@dillchen dillchen added the upcoming-release Should be included in the upcoming release label Jan 23, 2025
@dillchen dillchen removed the upcoming-release Should be included in the upcoming release label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salman-neslit salman-neslit

Labels
3 Full day task enhancement New feature or request
Projects
None yet
Milestone
groups and admin update
Development

Successfully merging a pull request may close this issue.

Update Permissions Selection UI + Add UPDATE_POLL hicommonwealth/commonwealth
3 participants
@dillchen @timolegros @salman-neslit