Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement improved "safe area" handling within mobile app. #10800

Open
burtonator opened this issue Jan 31, 2025 · 0 comments
Open

Implement improved "safe area" handling within mobile app. #10800

burtonator opened this issue Jan 31, 2025 · 0 comments
Assignees
Labels
bug Something isn't working needs estimate
Milestone

Comments

@burtonator
Copy link
Collaborator

Describe the bug

We can/should move the safe area handling into the webapp.

I realized that there's a hook that we can use to get the 'safe area offsets' that returns top, bottom , left, right and I can implement an async function so that the frontend can receive those values.

What we should then do is have the frontend read those values and do the safe area offset handling inside the webapp.

This also means our light/dark mode will work better and it will be easier to do things like custom onboarding which need the offset handled properly.

Initial conditions

Environment:

Branch/Release version:

Browser:

Wallet:

Reproduction steps

Actual behavior

Expected behavior

Screenshots / Video

Reporter

Additional context

@burtonator burtonator added bug Something isn't working needs estimate labels Jan 31, 2025
@burtonator burtonator added this to the Mobile App milestone Jan 31, 2025
@burtonator burtonator self-assigned this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs estimate
Projects
None yet
Development

No branches or pull requests

1 participant