Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chain logo broken on Profile #9283

Open
Israellund opened this issue Sep 19, 2024 · 2 comments · May be fixed by #9909
Open

Chain logo broken on Profile #9283

Israellund opened this issue Sep 19, 2024 · 2 comments · May be fixed by #9909
Assignees
@KaleemNeslit
Labels
1 1-2 hour task bug Something isn't working grab-n-go Quick tickets to grab and go with S1

Comments

@Israellund
Copy link
Collaborator

Israellund commented Sep 19, 2024 •
edited
Loading

Describe the bug

-the chain logo is broken when you view All Activity in Profile

https://commonwealth.im/profile/id/121279

Chrome:
Screenshot 2024-09-19 at 9 19 59 AM
Firefox:
image_360
@Israellund Israellund added bug Something isn't working grab-n-go Quick tickets to grab and go with needs estimate labels Sep 19, 2024
@dillchen dillchen added the S1 label Oct 11, 2024
@Israellund Israellund self-assigned this Oct 16, 2024
@Israellund Israellund added needs design 1 1-2 hour task and removed needs estimate labels Nov 4, 2024
@Israellund Israellund mentioned this issue Nov 12, 2024
Closed
@Israellund
Copy link
Collaborator Author

Randomize icons from this Figma to set as defualt icon_url property in all older communities that don't have it.
https://www.figma.com/design/YXdNM0hiwF5J0ylbmKuACT/Avatars?node-id=3076-41&t=Zn83ddpmX9VRbR0G-1

@dillchen dillchen assigned KaleemNeslit and unassigned Israellund Dec 17, 2024
@dillchen
Copy link
Contributor

@KaleemNeslit tagged you on this as it is upstream of #10264

devin-ai-integration bot added a commit that referenced this issue Dec 17, 2024
@devin-ai-integration @dillchen
feat: add chain profile and notification avatars
5b0e426 
- Add community icons to notification UI
- Fix chain logo display in profile page
- Add migration for default community avatars
- Add upload script for default avatars

Closes #9283
Closes #10279
Closes #10264

Co-Authored-By: Dillon Chen <[email protected]>
@devin-ai-integration devin-ai-integration bot mentioned this issue Dec 17, 2024
Closed
devin-ai-integration bot added a commit that referenced this issue Dec 17, 2024
@devin-ai-integration @dillchen
feat: add chain logo to profile page
fd671ea 
- Add chain logo display to profile header
- Add community info to profile model
- Position chain logo below profile image

Note: Default community avatars will be manually uploaded to S3 and links will be shared.

Closes #9283

Co-Authored-By: Dillon Chen <[email protected]>
@devin-ai-integration devin-ai-integration bot mentioned this issue Dec 17, 2024
Closed
3 tasks
@Israellund Israellund linked a pull request Feb 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaleemNeslit KaleemNeslit

Labels
1 1-2 hour task bug Something isn't working grab-n-go Quick tickets to grab and go with S1
Projects
None yet
Milestone
No milestone
3 participants
@dillchen @Israellund @KaleemNeslit