Fix repr of IntFlag enums (issue 47) #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enum._decompose method has been removed in newer versions of Python (at least >=3.11). The name indicates that it was private and should not have been used in the first place. The new implementation uses only documented public methods of the enum library.
davisdude
added a commit
to davisdude/py-slippi
that referenced
this pull request
Jul 4, 2023
hohav#49 commit ce75547 Author: Derek Brown <[email protected]> Date: Fri Mar 17 19:33:56 2023 -0400 Fix repr of IntFlag enums (issue 47) The enum._decompose method has been removed in newer versions of Python (at least >=3.11). The name indicates that it was private and should not have been used in the first place. The new implementation uses only documented public methods of the enum library. Co-authored-by: Derek Brown <[email protected]>
davisdude
added a commit
to davisdude/py-slippi
that referenced
this pull request
Jul 4, 2023
hohav#49 commit ce75547 Author: Derek Brown <[email protected]> Date: Fri Mar 17 19:33:56 2023 -0400 Fix repr of IntFlag enums (issue 47) The enum._decompose method has been removed in newer versions of Python (at least >=3.11). The name indicates that it was private and should not have been used in the first place. The new implementation uses only documented public methods of the enum library. Co-authored-by: Derek Brown <[email protected]>
davisdude
added a commit
to davisdude/py-slippi
that referenced
this pull request
Jul 4, 2023
hohav#49 commit ce75547 Author: Derek Brown <[email protected]> Date: Fri Mar 17 19:33:56 2023 -0400 Fix repr of IntFlag enums (issue 47) The enum._decompose method has been removed in newer versions of Python (at least >=3.11). The name indicates that it was private and should not have been used in the first place. The new implementation uses only documented public methods of the enum library. Co-authored-by: Derek Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
The enum._decompose method has been removed in newer versions of Python (at least >=3.11). The name indicates that it was private and should not have been used in the first place. The new implementation uses only documented public methods of the enum library. The repr format should be the exact same.