Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification Request: homebridge-aWATTar #765

Open
HerbertUnterberger opened this issue Oct 5, 2024 · 18 comments
Open

Verification Request: homebridge-aWATTar #765

HerbertUnterberger opened this issue Oct 5, 2024 · 18 comments
Labels
awaiting-changes use after review has started - awaiting user to make changes to plugin request-verification

Comments

@HerbertUnterberger
Copy link

HerbertUnterberger commented Oct 5, 2024

Plugin Name

homebridge-aWATTar

Link To GitHub Repo

https://github.com/HerbertUnterberger/homebridge-aWATTar

Plugin Icon (Optional)

image

The plugin does not offer the same nor less functionality than that of any existing verified plugin.

🟢 Yes

The plugin successfully installs and does not start unless it is configured.

🟢 Yes

The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.

🟢 Yes

The plugin does not contain any analytics or calls that enable you to track the user.

🟢 Yes

If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.

🟢 Yes

The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.

🟢 Yes

More Information

No issues since a week

thx for your platform

@HerbertUnterberger HerbertUnterberger added the pending the label given to a new verification/icon request label Oct 5, 2024
Copy link

github-actions bot commented Oct 5, 2024

🔴 The following checks failed:

  • Installation: failed to install [1]
  • Failed to install

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

@github-actions github-actions bot added awaiting-changes use after review has started - awaiting user to make changes to plugin and removed pending the label given to a new verification/icon request labels Oct 5, 2024
@HerbertUnterberger
Copy link
Author

Installation only fails in the first start, only when .Hombridge/.cache is missing.
In the second start the the directory .cache was created and it starts without error

@HerbertUnterberger
Copy link
Author

/check

@github-actions github-actions bot added pending the label given to a new verification/icon request and removed awaiting-changes use after review has started - awaiting user to make changes to plugin labels Oct 6, 2024
Copy link

github-actions bot commented Oct 6, 2024

🔴 The following checks failed:

  • Installation: failed to install [1]
  • Failed to install

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

@github-actions github-actions bot added awaiting-changes use after review has started - awaiting user to make changes to plugin and removed pending the label given to a new verification/icon request labels Oct 6, 2024
@HerbertUnterberger
Copy link
Author

/check
/check

@github-actions github-actions bot added pending the label given to a new verification/icon request and removed awaiting-changes use after review has started - awaiting user to make changes to plugin labels Oct 6, 2024
@HerbertUnterberger
Copy link
Author

Jap, I guess , Really ned help:

where do I check / create .Hombridge/.cache before running the Plugin?

@bwp91
Copy link
Contributor

bwp91 commented Oct 18, 2024

/check

Copy link

🔴 The following checks failed:

  • Installation: failed to install [1]
  • Failed to install

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

@github-actions github-actions bot added awaiting-changes use after review has started - awaiting user to make changes to plugin and removed pending the label given to a new verification/icon request labels Oct 18, 2024
@bwp91
Copy link
Contributor

bwp91 commented Oct 24, 2024

/check

@github-actions github-actions bot added pending the label given to a new verification/icon request and removed awaiting-changes use after review has started - awaiting user to make changes to plugin labels Oct 24, 2024
Copy link

🔴 The following checks failed:

  • Installation: failed to install [1]
  • Failed to install

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

@github-actions github-actions bot added awaiting-changes use after review has started - awaiting user to make changes to plugin and removed pending the label given to a new verification/icon request labels Oct 24, 2024
@bwp91
Copy link
Contributor

bwp91 commented Oct 24, 2024

/check

@github-actions github-actions bot added pending the label given to a new verification/icon request and removed awaiting-changes use after review has started - awaiting user to make changes to plugin labels Oct 24, 2024
Copy link

🔴 The following checks failed:

  • GitHub Repo: should have issues enabled

🟢 The following checks passed:

  • Installation: successfully installed
  • Package JSON: homepage exists
  • Package JSON: bugs.url exists and seems a valid URL
  • Package JSON: keywords exist and contain 'homebridge-plugin'
  • Package JSON: 'preinstall' in scripts is not present
  • Package JSON: 'install' in scripts is not present
  • Package JSON: 'postinstall' in scripts is not present
  • Package JSON: engines.node property is compatible with Node 18
  • Package JSON: engines.node property is compatible with Node 20
  • Package JSON: engines.homebridge property is compatible with Homebridge 1.8.4
  • Package JSON: initializer function found
  • GitHub Repo: repository is public
  • GitHub Repo: repository is not archived
  • GitHub Repo: contains releases
  • NPM Package: has not been deprecated
  • Config Schema JSON: exists and is valid JSON
  • Config Schema JSON: contains a valid pluginAlias
  • Config Schema JSON: the pluginType is set to 'platform'
  • Config Schema JSON: contains a name schema property
  • Dependencies: homebridge was not installed as a dependency
  • Dependencies: hap-nodejs was not installed as a dependency

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

@github-actions github-actions bot added awaiting-changes use after review has started - awaiting user to make changes to plugin and removed pending the label given to a new verification/icon request labels Oct 24, 2024
@bwp91
Copy link
Contributor

bwp91 commented Oct 24, 2024

@HerbertUnterberger one more thing to sort ^

@HerbertUnterberger
Copy link
Author

/check

@github-actions github-actions bot added pending the label given to a new verification/icon request and removed awaiting-changes use after review has started - awaiting user to make changes to plugin labels Oct 27, 2024
Copy link

🟢 The following checks passed:

  • Installation: successfully installed
  • Package JSON: homepage exists
  • Package JSON: bugs.url exists and seems a valid URL
  • Package JSON: keywords exist and contain 'homebridge-plugin'
  • Package JSON: 'preinstall' in scripts is not present
  • Package JSON: 'install' in scripts is not present
  • Package JSON: 'postinstall' in scripts is not present
  • Package JSON: engines.node property is compatible with Node 18
  • Package JSON: engines.node property is compatible with Node 20
  • Package JSON: engines.homebridge property is compatible with Homebridge 1.8.5
  • Package JSON: initializer function found
  • GitHub Repo: repository is public
  • GitHub Repo: repository is not archived
  • GitHub Repo: issues are enabled
  • GitHub Repo: contains releases
  • NPM Package: has not been deprecated
  • Config Schema JSON: exists and is valid JSON
  • Config Schema JSON: contains a valid pluginAlias
  • Config Schema JSON: the pluginType is set to 'platform'
  • Config Schema JSON: contains a name schema property
  • Dependencies: homebridge was not installed as a dependency
  • Dependencies: hap-nodejs was not installed as a dependency

🎉 All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

@bwp91
Copy link
Contributor

bwp91 commented Dec 29, 2024

/check

Copy link

🔴 The following checks failed:

  • Package JSON: engines.node property is not compatible with Node 22

🟢 The following checks passed:

  • Installation: successfully installed
  • Package JSON: homepage exists
  • Package JSON: bugs.url exists and seems a valid URL
  • Package JSON: keywords exist and contain 'homebridge-plugin'
  • Package JSON: 'preinstall' in scripts is not present
  • Package JSON: 'install' in scripts is not present
  • Package JSON: 'postinstall' in scripts is not present
  • Package JSON: engines.node property is compatible with Node 18
  • Package JSON: engines.node property is compatible with Node 20
  • Package JSON: engines.homebridge property is compatible with Homebridge 1.8.5
  • Package JSON: initializer function found
  • GitHub Repo: repository is public
  • GitHub Repo: repository is not archived
  • GitHub Repo: issues are enabled
  • GitHub Repo: contains releases
  • NPM Package: has not been deprecated
  • Config Schema JSON: exists and is valid JSON
  • Config Schema JSON: contains a valid pluginAlias
  • Config Schema JSON: the pluginType is set to 'platform'
  • Config Schema JSON: contains a name schema property
  • Dependencies: homebridge was not installed as a dependency
  • Dependencies: hap-nodejs was not installed as a dependency

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

These checks were run against v1.5.0 of the plugin.

@github-actions github-actions bot added awaiting-changes use after review has started - awaiting user to make changes to plugin and removed pending the label given to a new verification/icon request labels Dec 29, 2024
@bwp91
Copy link
Contributor

bwp91 commented Dec 29, 2024

@HerbertUnterberger please update the package.json engines.node property to show compatibility with node 22.

Something like "node": "^18.17.0 || ^20.9.0 || ^22.12.0"

This is assuming the plugin works on node 22!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-changes use after review has started - awaiting user to make changes to plugin request-verification
Projects
None yet
Development

No branches or pull requests

2 participants