Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change message format when including node as delegate to Staking Safe #4

Open
2 tasks
QYuQianchen opened this issue Apr 18, 2024 · 2 comments
Open
2 tasks

Comments

@QYuQianchen
Copy link
Contributor

To add a node as a delegate to a Safe, it requires a signature from a Safe owner via POST /v1/delegates/ endpoint (see https://safe-transaction-mainnet.safe.global/). The message to be signed is currently only a concatenated string and thus not compatible to EIP-712.
Changes need to be introduced:

  • Introduce changes in hoprnet/safe-transaction-service link to accept EIP712
  • Update StakingHub so that the "add delegate" step prepares a EIP712-compatible message and asks for admin signature
@mjadach-iv
Copy link
Collaborator

mjadach-iv commented Apr 18, 2024

Issue was reported to Safe too, and they said they will implement it:
safe-global/safe-transaction-service#1857 (comment)

@mjadach-iv mjadach-iv transferred this issue from hoprnet/hopr-admin May 13, 2024
@mjadach-iv
Copy link
Collaborator

Seems we can work on it now, need to verify with our safe infra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants