Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove geometries that do not match primary mapping geometry type #2226

Open
spwoodcock opened this issue Feb 24, 2025 · 0 comments
Open

Remove geometries that do not match primary mapping geometry type #2226

spwoodcock opened this issue Feb 24, 2025 · 0 comments
Labels
backend Related to backend code bug Something isn't working effort:low Likely a few hours priority:low Backlog of tasks that will be addressed in time

Comments

@spwoodcock
Copy link
Member

Describe the bug

  • During project creation the user can upload mixed geometries, or the data extract via raw-data-api is often mixed.
  • The user specifies they want to map a particular geom type.
  • There is a mismatch here: the user has points to map when the specified they are mapping polygons.

Follow on from #2225

Expected behavior

We need to either:

  1. Strip all geoms that do not match the primary mapping geom type. This is easy for custom data extracts. For raw-data-api data extracts, prerequisites are Allow project creators to select specific feature types for OSM data download #2193 and Data extracts from raw-data-api should always be downloaded, update project creation workflow #2175
  2. OR allow the mapping of mixed geometry types. But to enable this we need to fix the styling of both geometry types at once in the svelte-maplibre map component of the mapper frontend.

The question is: do we ever need to map mixed geometry types at the same time?
If so, this probably adds significant complication - is the gain worth it?

@spwoodcock spwoodcock added backend Related to backend code bug Something isn't working effort:low Likely a few hours priority:low Backlog of tasks that will be addressed in time labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working effort:low Likely a few hours priority:low Backlog of tasks that will be addressed in time
Projects
Development

No branches or pull requests

1 participant