Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICFolder uses name #255

Closed
timgarrels opened this issue Jul 11, 2019 · 1 comment
Closed

ICFolder uses name #255

timgarrels opened this issue Jul 11, 2019 · 1 comment
Labels
bug Wrong behaviour that needs to be fixed refactor

Comments

@timgarrels
Copy link
Contributor

ICFolder overwrites the object getter name. name is supposed to be accountName which was an issue in endpoint before as well.

A change of that getter might change the UI, as the toolbuilder was told (at least for the endpoint part) to use the object name, and not a more fitting variable like accountName

This requires changes in Core and UI as well
@timgarrels timgarrels added bug Wrong behaviour that needs to be fixed refactor labels Jul 11, 2019
@timgarrels timgarrels mentioned this issue Jul 19, 2019
Merged
@timgarrels
Copy link
Contributor Author

This was fixed by #262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Wrong behaviour that needs to be fixed refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timgarrels