Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruby version and gems #653

Open
2 tasks
tbjoern opened this issue Sep 27, 2018 · 0 comments
Open
2 tasks

Update ruby version and gems #653

tbjoern opened this issue Sep 27, 2018 · 0 comments

Comments

@tbjoern
Copy link
Contributor

tbjoern commented Sep 27, 2018

Its been a long time since the project was created. The ruby version and gems are outdated.
They have been updated in the update_ruby_and_gems branch.

Noteable changes and findings:
FactoryGirl was replaced with FactoryBot
FactoryBot.attributes_for(:model, attribute: value) will not incorporate the attribute: value pair in the result hash.

TODOs:

  • search for instances of attributes_for and check if the tests using it work as intended.
  • merge current dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant