Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require explicit passing of context #7

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

sloede
Copy link
Member

@sloede sloede commented Jan 19, 2024

Fixes #4

SecureVector and PlainVector are created with a context and thus require no extra passing of a context in any function that has arguments of that type.

@sloede sloede enabled auto-merge January 19, 2024 13:13
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (695394e) 86.09% compared to head (ff73856) 87.97%.

Files Patch % Lines
src/openfhe.jl 90.90% 1 Missing ⚠️
src/unencrypted.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   86.09%   87.97%   +1.88%     
==========================================
  Files           7        7              
  Lines         187      183       -4     
==========================================
  Hits          161      161              
+ Misses         26       22       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede sloede disabled auto-merge January 19, 2024 13:15
@sloede sloede enabled auto-merge January 19, 2024 13:15
@sloede sloede closed this Jan 19, 2024
auto-merge was automatically disabled January 19, 2024 13:18

Pull request was closed

@sloede sloede reopened this Jan 19, 2024
@sloede sloede enabled auto-merge January 19, 2024 13:18
@sloede sloede merged commit 8211826 into main Jan 19, 2024
22 of 23 checks passed
@sloede sloede deleted the msl/simplify-usage branch January 19, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid passing the SecureContext explicitly
1 participant