Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.1 on CRAN and anaconda? #72

Closed
Thomas-Hirsch opened this issue Jan 22, 2020 · 11 comments
Closed

v1.0.1 on CRAN and anaconda? #72

Thomas-Hirsch opened this issue Jan 22, 2020 · 11 comments

Comments

@Thomas-Hirsch
Copy link

Big fan of the waffle package! Just wondering, currently CRAN only has v0.7. When is v1.0.1 likely to make its way to CRAN? I'm also interested in getting it on anaconda.org, which we use in our organisation. It appears that it's relatively straightforward to get CRAN packages onto anaconda, but as v1.0.1 is only available on github and your CRAN mirror, it's a bit more complex. I'm particularly keen to make use of geom_waffle() which only appears in v1.0.1 (I wrote a chart with geom_waffle and I'd rather not have to rewrite with waffle())

@jntrcs
Copy link

jntrcs commented Jul 14, 2020

Seconded to everything. CRAN needs geom_waffle()!

@jolars
Copy link

jolars commented Mar 18, 2021

Yes, it would be great. I'm running a course in data visualization and would love to use waffle on the course but cannot expect students to download development versions of packages off of GitHub. Is there any outstanding issues that you think needs fixing before this is submitted to CRAN, @hrbrmstr ? I'd be glad to help out with pull requests to facilitate a CRAN update.

@AndrewKostandy
Copy link

AndrewKostandy commented Aug 29, 2021

I add my vote to the above request. Releasing the updated version on CRAN would be great!

@skgithub14
Copy link

Having v1.0.1 on CRAN would be very helpful for me. My company uses a commercial R Connect account to host Shiny apps and R Connect struggles with deploying non-CRAN packages. Are there plans to get the new version on CRAN?

@hdolinh
Copy link

hdolinh commented Aug 2, 2022

+1 for adding v1.0.1 on CRAN. I'm building a shiny app and can't use my waffle visual built with geom_waffle because shiny can't deploy development versions of packages from GitHub

@rempsyc
Copy link

rempsyc commented Sep 30, 2023

Same here, I use geom_waffle() in my package pubmedDashboard but cannot probably submit to CRAN because of the following R CMD check warning:

checking dependencies in R code ... WARNING
  Missing or unexported object:waffle::geom_waffle

@hrbrmstr
Copy link
Owner

🤞🏽

> devtools::check_mac_release()
Building macOS version of waffle (1.0.2)
ℹ Using
  https://mac.r-project.org/macbuilder/submit.html.
── R CMD build ───────────────────────────────────────
✔  checking for file ‘/Users/hrbrmstr/packages/waffle/DESCRIPTION’ ...
─  preparing ‘waffle’:
✔  checking DESCRIPTION meta-information ...
─  installing the package to build vignettes
✔  creating vignettes (12.9s)
─  checking for LF line-endings in source and make files and shell scripts
─  checking for empty or unneeded directories
─  building ‘waffle_1.0.2.tar.gz’
   
──────────────────────────────────────────────────────
ℹ Check
  <https://mac.R-project.org/macbuilder/results/1696102973-2c8d8c74176d8e7d/>
  the results in 5-10 mins (~03:52 PM).
> devtools::check_win_devel()
Building windows version of waffle (1.0.2)
ℹ Using R-devel with win-builder.r-project.org.
Email results to [email protected]?

1: Yeah
2: No
3: Uhhhh... Maybe?

Selection: 1
── R CMD build ───────────────────────────────────────
✔  checking for file ‘/Users/hrbrmstr/packages/waffle/DESCRIPTION’ ...
─  preparing ‘waffle’:
✔  checking DESCRIPTION meta-information ...
─  installing the package to build vignettes
✔  creating vignettes (12.9s)
─  checking for LF line-endings in source and make files and shell scripts
─  checking for empty or unneeded directories
─  building ‘waffle_1.0.2.tar.gz’
   
──────────────────────────────────────────────────────
ℹ Check <[email protected]> for the results in 15-30 mins
  (~04:13 PM).

@hrbrmstr
Copy link
Owner

fixed the annoying na.rm thing while I was at it.

no promises tho if CRAN finds stuff wrong that the two CRAN check services do not. I have zero patience for them.

@hrbrmstr
Copy link
Owner

Still no guarantee but

[This was generated from [CRAN.R-project.org/submit.html](http://cran.r-project.org/submit.html)]

The following package was uploaded to CRAN:
===========================================

Package Information:
Package: waffle
Version: 1.0.2
Title: Create Waffle Chart Visualizations
Author(s): Bob Rudis [aut, cre] (<https://orcid.org/0000-0001-5670-2640>),
  Dave Gandy [aut] (Font Awesome), Andrew Breza [ctb], Matthias
  Jütte [ctb], Paul Campbell [ctb] (geom_bar flip)
Maintainer: Bob Rudis <[[email protected]](mailto:[email protected])>
Depends: R (>= 3.5.0), ggplot2 (>= 3.1.0)
Suggests: knitr, rmarkdown, dplyr, ggthemes
Description: Square pie charts (a.k.a. waffle charts) can be used to
  communicate parts of a whole for categorical quantities. To
  emulate the percentage view of a pie chart, a 10x10 grid
  should be used with each square representing 1% of the total.
  Modern uses of waffle charts do not necessarily adhere to
  this rule and can be created with a grid of any rectangular
  shape. Best practices suggest keeping the number of
  categories small, just as should be done when creating pie
  charts. Tools are provided to create waffle charts as well as
  stitch them together, and to use glyphs for making isotype
  pictograms.
License: GPL (>= 2)
Imports: RColorBrewer, grid, gridExtra, gtable, extrafont, curl,
  stringr, stats, htmlwidgets, DT, plyr, rlang, utils


The maintainer confirms that he or she
has read and agrees to the CRAN policies.

@hrbrmstr
Copy link
Owner

Dear maintainer,

thanks, package waffle_1.0.2.tar.gz is on its way to CRAN.

Best regards,
CRAN teams' auto-check service
Package check result: OK

No changes to worse in reverse depends.

@rempsyc
Copy link

rempsyc commented Sep 30, 2023

Great news, congratulations and thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants